Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tags on deprecated settings. NFC #23971

Merged
merged 1 commit into from
Mar 24, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix tags on deprecated settings. NFC
  • Loading branch information
sbc100 committed Mar 22, 2025
commit f5fd1edf784711dbb13bf459f0277fa5d93c824d
4 changes: 4 additions & 0 deletions site/source/docs/tools_reference/settings_reference.rst
Original file line number Diff line number Diff line change
@@ -469,6 +469,8 @@ emulated values may not match (this is true of native too, for that matter -
this is all undefined behavior). This approaches appears good enough to
support Python, which is the main use case motivating this feature.

.. note:: This setting is deprecated

Default value: false

.. _exception_debug:
@@ -3096,6 +3098,8 @@ normal wasm or that wasm2js code. For details of how to do that, see the
test_maybe_wasm2js test. This option can be useful for debugging and
bisecting.

.. note:: This setting is deprecated

Default value: false

.. _asan_shadow_size:
2 changes: 2 additions & 0 deletions src/settings.js
Original file line number Diff line number Diff line change
@@ -344,6 +344,7 @@ var SAFE_HEAP_LOG = false;
// this is all undefined behavior). This approaches appears good enough to
// support Python, which is the main use case motivating this feature.
// [link]
// [deprecated]
var EMULATE_FUNCTION_POINTER_CASTS = false;

// Print out exceptions in emscriptened code.
@@ -2027,6 +2028,7 @@ var MINIFY_HTML = true;
// test_maybe_wasm2js test. This option can be useful for debugging and
// bisecting.
// [link]
// [deprecated]
var MAYBE_WASM2JS = false;

// This option is no longer used. The appropriate shadow memory size is now
2 changes: 2 additions & 0 deletions tools/settings.py
Original file line number Diff line number Diff line change
@@ -117,6 +117,8 @@
#
# At some point in the future, once folks have stopped using these
# settings we can move them to `LEGACY_SETTINGS`.
#
# All settings here should be tagged as `[deprecated]` in settings.js
DEPRECATED_SETTINGS = {
'SUPPORT_ERRNO': 'emscripten no longer uses the setErrNo library function',
'EXTRA_EXPORTED_RUNTIME_METHODS': 'please use EXPORTED_RUNTIME_METHODS instead',