-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FLOAT32 formats #9852
base: main
Are you sure you want to change the base?
Add FLOAT32 formats #9852
Conversation
Thank you for submitting a pull request! If this is your first PR, make sure to add yourself to AUTHORS. |
Thanks @TimDaub ! Yes, this looks right to me, I'm puzzled why it wasn't there before... perhaps @juj has an idea? I suspect we didn't want to add extra changes to I think we can also remove the |
7ee3daa
to
86771ab
Compare
OK, I removed them. |
- Added AL_FORMAT_MONO_FLOAT32 and AL_FORMAT_STEREO_FLOAT32 to al.h - Remove custom definition of these values from tests
86771ab
to
d5a423e
Compare
The FLOAT32 #defines are not part of OpenAL (https://github.com/kcat/openal-soft/blob/master/include/AL/al.h), but they are an extension to OpenAL, see If we want to do this proper, we should also add a file alext.h in https://github.com/emscripten-core/emscripten/tree/incoming/system/include/AL where this should live. Perhaps we should take openal-soft headers as-is from https://github.com/kcat/openal-soft/tree/master/include/AL ? (although that will run into similar problems as WebGL currently does with mismatching/unrecognized extensions, but with OpenAL it may be easier to add support to each) |
Thanks @juj, yes, that sounds like the way to go! |
The deletion of the Re-opening and re-targeting to master. |
This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 30 days. Feel free to re-open at any time if this issue is still relevant. |
Any progress on this one? |
Fixes #9851