Tests: Add a CMake option to disable the main catch all exceptions (#2076)

 - Add a CMake option to control the behavior of the main.cxx catch all exceptions
 - Use it in CI
 - Coverage reduction is expected and I believe a good idea to unsure this part of the code *is not* covered.

Author: mwestphal

.github/actions/generic-ci/action.yml

@@ -209,6 +209,7 @@ runs:
         -DF3D_TESTING_ENABLE_GLX_TESTS=${{ (runner.os == 'Linux' && inputs.rendering_backend == 'auto') && 'ON' || 'OFF' }}
         -DF3D_TESTING_ENABLE_LONG_TIMEOUT_TESTS=${{ (runner.os == 'Linux' || runner.os == 'Windows') && 'ON' || 'OFF' }}
         -DF3D_TESTING_ENABLE_OSMESA_TESTS=${{ runner.os == 'Linux' && 'ON' || 'OFF' }}
+        -DF3D_TESTING_DISABLE_CATCH_ALL=ON
         -DF3D_TESTING_FORCE_RENDERING_BACKEND=${{ inputs.rendering_backend }}
         -DF3D_WINDOWS_GUI=ON
         ${{ runner.os == 'Windows' && '-Ax64 -DCMAKE_MSVC_RUNTIME_LIBRARY=MultiThreadedDLL' || null }}

CMakeLists.txt

@@ -202,6 +202,7 @@ cmake_dependent_option(F3D_TESTING_ENABLE_LONG_TIMEOUT_TESTS "Enable long timeou
 cmake_dependent_option(F3D_TESTING_ENABLE_GLX_TESTS "Enable tests that require a X server running on Linux" ON "F3D_TESTING_ENABLE_RENDERING_TESTS AND UNIX AND NOT APPLE" OFF)
 cmake_dependent_option(F3D_TESTING_ENABLE_EGL_TESTS "Enable tests that require EGL to run" ON "F3D_TESTING_ENABLE_RENDERING_TESTS AND UNIX AND NOT APPLE" OFF)
 cmake_dependent_option(F3D_TESTING_ENABLE_OSMESA_TESTS "Enable tests that require OSMESA to run" ON "F3D_TESTING_ENABLE_RENDERING_TESTS AND UNIX AND NOT APPLE" OFF)
+cmake_dependent_option(F3D_TESTING_DISABLE_CATCH_ALL "Disable the catch all exception code in main for improved testing" OFF "BUILD_TESTING" OFF)
 
 if(BUILD_TESTING)
   enable_testing()

application/CMakeLists.txt

@@ -136,6 +136,11 @@ if(F3D_STRICT_BUILD)
   endif()
 endif()
 
+# F3D_TESTING_DISABLE_CATCH_ALL
+if (F3D_TESTING_DISABLE_CATCH_ALL)
+  target_compile_definitions(f3d PRIVATE F3D_TESTING_DISABLE_CATCH_ALL)
+endif ()
+
 # Coverage
 list(APPEND f3d_compile_options_public ${f3d_coverage_compile_options})
 list(APPEND f3d_link_options_public ${f3d_coverage_link_options})

application/main.cxx

@@ -22,12 +22,14 @@ int main(int argc, char** argv)
     // exit with error when needed
     exit(EXIT_FAILURE);
   }
+#ifndef F3D_TESTING_DISABLE_CATCH_ALL
   catch (const std::exception& ex)
   {
     f3d::log::error("F3D encountered an unexpected exception:");
     f3d::log::error(ex.what());
     exit(EXIT_FAILURE);
   }
+#endif
 
   return res;
 }