Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a CLI option to select reader to use #1735

Open
mwestphal opened this issue Nov 26, 2024 · 4 comments · May be fixed by #1860
Open

Add a CLI option to select reader to use #1735

mwestphal opened this issue Nov 26, 2024 · 4 comments · May be fixed by #1860
Assignees
@0xfedcafe
Labels
help wanted Please help with this issue! source:F3DApplication
Milestone
3.2.0

Comments

@mwestphal
Copy link
Contributor

Is your feature request related to a problem? Please describe.
F3D rely on file extension to detect which reader to use, but sometimes this detection is not enough. Moreover, F3D can have multiple readers for the same extension, in that case it is not possible to choose which one to use.

Describe the solution you'd like

  • Add a CLI option to select the reader to use based on its name.
  • Pass this option to the reader selection mechanism to force it
  • Add a test, the draco/gltf readers are a possible candidate for testing this
@mwestphal mwestphal added this to F3D Nov 26, 2024
@mwestphal mwestphal moved this to To do in F3D Nov 26, 2024
@mwestphal mwestphal added this to the 3.1.0 milestone Dec 19, 2024
@0xfedcafe
Copy link
Contributor

I’m interested in working on this issue. Would it be okay for me to take it?

@mwestphal
Copy link
Contributor Author

Of course, I just assigned it.

@mwestphal
Copy link
Contributor Author

Do not hesitate to discuss the feature on discord if needed :)

@0xfedcafe 0xfedcafe linked a pull request Jan 3, 2025 that will close this issue
Open
@mwestphal mwestphal modified the milestones: 3.1.0, 3.2.0 Feb 27, 2025
@mwestphal
Copy link
Contributor Author

Adressed by: #1860

@mwestphal mwestphal linked a pull request Mar 1, 2025 that will close this issue
Cli reader options #1860
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xfedcafe 0xfedcafe

Labels
help wanted Please help with this issue! source:F3DApplication
Projects
F3D
Status: To do
Milestone
3.2.0
Development

Successfully merging a pull request may close this issue.

Cli reader options 0xfedcafe/f3d
2 participants
@mwestphal @0xfedcafe