Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CLI option to generate an animated camera orbit #1743

Open
Tracked by #841
mwestphal opened this issue Dec 2, 2024 · 7 comments · May be fixed by #2016
Open
Tracked by #841

Add a CLI option to generate an animated camera orbit #1743

mwestphal opened this issue Dec 2, 2024 · 7 comments · May be fixed by #2016
Assignees
Labels
Milestone

Comments

@mwestphal
Copy link
Contributor

Is your feature request related to a problem? Please describe.
F3D supports loading camera from files and provide a --camera-index CLI option to select it. F3D also support animation which could animation the selected camera. However, many file do not have any camera nor animations.

Lets add a dedicated CLI option to add an animated camera orbit

Suggested implementation

  • Add a CLI options --camera-orbit that let user specify the time to complete orbit
  • When used, this will add an animation with good default if there is none, or rely on existing animation if there is some
  • Add dedicated logic in animationManager::tick to update camera accordingly to camera parameters
  • Should support loading correctly at any time
  • Add tests
@mwestphal mwestphal added this to F3D Dec 2, 2024
@mwestphal mwestphal moved this to In progress in F3D Dec 2, 2024
@mwestphal mwestphal moved this from In progress to To do in F3D Dec 2, 2024
@mwestphal
Copy link
Contributor Author

related to #46

@mwestphal mwestphal added this to the 3.1.0 milestone Dec 19, 2024
@v0id-strike
Copy link
Contributor

v0id-strike commented Jan 27, 2025

So, idea is adding default camera path when there is none. and traveling that path within given time. If so i am taking this

@mwestphal
Copy link
Contributor Author

The idea is to be able to do a simple orbit over time, yes.

@mwestphal
Copy link
Contributor Author

Hi @v0id-strike

How is it going ? Do you need any help ?

@v0id-strike
Copy link
Contributor

yeap. going well. will open Pull request by tommorow

@v0id-strike
Copy link
Contributor

Sorry. i was supposed to open pull request today. and ran into issue

@mwestphal mwestphal modified the milestones: 3.1.0, 3.2.0 Feb 27, 2025
@mwestphal
Copy link
Contributor Author

Adressed here: #2016

@mwestphal mwestphal linked a pull request Mar 1, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: To do
Development

Successfully merging a pull request may close this issue.

2 participants