Cli reader options #1860
Cli reader options #1860
Conversation
|
You are modifying libf3d public API! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1860 +/- ##
==========================================
- Coverage 95.79% 95.76% -0.03%
==========================================
Files 128 128
Lines 10396 10398 +2
==========================================
- Hits 9959 9958 -1
- Misses 437 440 +3 ☔ View full report in Codecov by Sentry. |
|
Do you need any help or review to move forward @0xfedcafe ? |
Just that upper question about an optional and I’ll push hopefully the final commit for this task with the test |
|
Hi @0xfedcafe How is it going ? Do you need any help ? |
|
Hi @0xfedcafe Please do not hesitate to reach out if you need any guidance :) |
|
Hi @0xfedcafe ! Do you need a review or help with CI ? |
yes, i think a hint would be very helpful. i can't find why in some tests where the necessary plugins are loaded and the reader is not nullptr it still fails with "unsupported file format" |
| @@ -44,7 +46,7 @@ class factory | |||
| /** | |||
| * Get the reader that can read the given file, nullptr if none | |||
| */ | |||
| reader* getReader(const std::string& fileName); | |||
| reader* getReader(const std::string& fileName, std::optional<std::string_view> forceReader); | |||
There was a problem hiding this comment.
im not sure about the the use of a std::optionalstd::string_view here. Isnt the force_reader option a std::optionalstd::string ? Is it converted seamlessly ?
There was a problem hiding this comment.
oh, i thought that it would be converted seamlessly, but now i'm unsure, i'll check that, thanks!
fixes by mwestphal Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>
|
There a small conflict to fix with master, let me know if you need help with that |
Added a CLI reader option #1735