Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unused variables #935

Merged
merged 7 commits into from
Feb 10, 2025
Merged

Removed unused variables #935

merged 7 commits into from
Feb 10, 2025

Conversation

jvdp1
Copy link
Member

@jvdp1 jvdp1 commented Feb 9, 2025

Here is a PR to remove some unused variables in various parts of stdlib.

@jvdp1 jvdp1 requested review from perazz and jalvesz February 9, 2025 17:10
perazz
perazz approved these changes Feb 9, 2025
View reviewed changes
Copy link
Member

@perazz perazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @jvdp1, thank you for a useful code cleanup.

jalvesz
jalvesz approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@jalvesz jalvesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @jvdp1, thanks for the clean up!

@perazz
Copy link
Member

perazz commented Feb 10, 2025

Thank you @jvdp1 for the PR and @jalvesz for the reviews: with two approvals, I think this is ready to be merged.

@jvdp1
Copy link
Member Author

jvdp1 commented Feb 10, 2025

Thank you for your quick answers. I will merge it.

@jvdp1 jvdp1 merged commit bec8574 into fortran-lang:master Feb 10, 2025
14 checks passed
@jvdp1 jvdp1 deleted the clean_lapack branch February 10, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perazz perazz

@jalvesz jalvesz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jvdp1 @perazz @jalvesz