Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system: is_directory #946

Merged
merged 7 commits into from
Mar 24, 2025
Merged

system: is_directory #946

merged 7 commits into from
Mar 24, 2025

Conversation

perazz
Copy link
Member

@perazz perazz commented Mar 7, 2025

This PR is spun off #904 for clarity.

  • It provides a logical function to evaluate whether a given path is a directory.
  • On Windows, it natively works both with / and \ separators.
  • Relies on C functions, to avoid Fortran pre-processor macros and path swapping, that would be slow.

Some questions to discuss that come to my mind:

  • Should this be part of stdlib_system, stdlib_io, or maybe a submodule(stdlib_system) stdlib_system_filesystem? or else?
  • Should we begin standardizing the C-side names somehow? They use the same global namespace, so we should start being careful imho.

cc: @jvdp1 @jalvesz

@perazz perazz requested review from jalvesz and jvdp1 March 21, 2025 07:18
@perazz
Copy link
Member Author

perazz commented Mar 21, 2025

@jalvesz @jvdp1 @fortran-lang/stdlib mind if I bring your attention to this short PR? If we could get to handle it soon, I would be able to port more of the more complex filesystem operations to stdlib.

Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @perazz

Copy link
Contributor

@jalvesz jalvesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @perazz! Thank for this nice PR!!

@perazz
Copy link
Member Author

perazz commented Mar 22, 2025

Thank you @jvdp1 @jalvesz, let's wait a bit more, and then we can merge imho.

@perazz perazz merged commit 2bdc50e into fortran-lang:master Mar 24, 2025
14 checks passed
@perazz
Copy link
Member Author

perazz commented Mar 24, 2025

Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants