Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite snforge plugin to new macro syntax #2858

Open
cptartur opened this issue Jan 17, 2025 · 1 comment · May be fixed by #3068
Open

Rewrite snforge plugin to new macro syntax #2858

cptartur opened this issue Jan 17, 2025 · 1 comment · May be fixed by #3068
Assignees
@ddoktorski
Labels
maintenance scarb snforge

Comments

@cptartur
Copy link
Member

No description provided.

@cptartur cptartur converted this from a draft issue Jan 17, 2025
@github-actions github-actions bot added the new label Jan 17, 2025
@cptartur
Copy link
Member Author

Not yet released

@cptartur cptartur moved this from Backlog to TODO in Starknet foundry Feb 3, 2025
@cptartur cptartur moved this from TODO to In Progress in Starknet foundry Feb 10, 2025
@cptartur cptartur removed the blocked label Feb 10, 2025
@ddoktorski ddoktorski mentioned this issue Mar 6, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Mar 7, 2025
@ddoktorski
Assert plugin outputs with Cairo formatter (#3059)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
288f9d4 
<!-- Reference any GitHub issues resolved by this PR -->

Towards #2858 

## Introduced changes

<!-- A brief description of the changes -->

- With new macro syntax, the returned code is formatted differently than
before, and our current logic does not normalize it correctly for
asserts. Instead of replacing whitespaces with a single space, apply the
Cairo formatter and remove newlines.
@ddoktorski ddoktorski linked a pull request Mar 10, 2025 that will close this issue
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddoktorski ddoktorski

Labels
maintenance scarb snforge
Projects
Starknet foundry
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate to new macro syntax foundry-rs/starknet-foundry
2 participants
@ddoktorski @cptartur