-
Notifications
You must be signed in to change notification settings - Fork 7
/
Copy pathprefer-flat.js
60 lines (57 loc) · 2.49 KB
/
prefer-flat.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
/**
* @license MIT
* @author Martin Giger
*/
const
firstElement = ([ first ]) => first,
secondElement = ([
, second,
]) => second;
export default {
meta: {
docs: {
description: "Prefer using .flat() over concatenating to flatten an array.",
recommended: true,
},
schema: [],
fixable: "code",
type: "suggestion",
messages: {
preferFlat: "Use flat to flatten an array",
},
},
create(context) {
return {
'CallExpression[callee.type="MemberExpression"][callee.property.name="concat"][callee.object.type="ArrayExpression"][callee.object.elements.length=0] > SpreadElement'(node) {
node = node.parent;
context.report({
node,
messageId: "preferFlat",
fix(fixer) {
const { sourceCode } = context;
//TODO could be an iterable, so Array.from may be needed.
return fixer.replaceText(node, `${sourceCode.getText(firstElement(node.arguments).argument)}.flat()`);
},
});
},
'CallExpression[callee.type="MemberExpression"][callee.property.name="reduce"][arguments.length=2][arguments.1.type=ArrayExpression][arguments.1.elements.length=0] > *:function[params.length=2][params.0.type=Identifier][params.1.type=Identifier] > CallExpression[callee.type="MemberExpression"][callee.property.name="concat"][arguments.length=1][arguments.0.type=Identifier]'(node) {
const reduceCallbackParameters = node.parent.params;
// arr.reducer((a, b) => a.concat(b), [])
// "concat" function must be called on "a" and concat argument must be "b".
if(
firstElement(node.arguments).name === secondElement(reduceCallbackParameters).name &&
node.callee.object.name === firstElement(reduceCallbackParameters).name
) {
context.report({
node: node.parent.parent,
messageId: "preferFlat",
fix(fixer) {
const { sourceCode } = context;
return fixer.replaceText(node.parent.parent, `${sourceCode.getText(node.parent.parent.callee.object)}.flat()`);
},
});
}
},
};
},
};