Redash DB migration error - tuple index out of range

[cynicaljoy]

Issue Summary

Upgrading from redash/redash:10.1.0.b50633 to redash/redash:25.1.0 -- db migration fails. I updated my docker compose file to use pgautoupgrade/pgautoupgrade:latest

Steps to Reproduce

$ docker compose run --rm server manage db upgrade
[2025-02-02 21:15:59,538][PID:1][INFO][xmlschema] Resource 'XMLSchema.xsd' is already loaded
[2025-02-02 21:16:00,314][PID:1][INFO][alembic.runtime.migration] Context impl PostgresqlImpl.
[2025-02-02 21:16:00,314][PID:1][INFO][alembic.runtime.migration] Will assume transactional DDL.
[2025-02-02 21:16:00,334][PID:1][INFO][alembic.runtime.migration] Running upgrade 89bc7873a3e0 -> fd4fc850d7ea, Convert user details to jsonb and move user profile image url into details column
[2025-02-02 21:16:00,358][PID:1][INFO][alembic.runtime.migration] Running upgrade fd4fc850d7ea -> 1038c2174f5d, Make case insensitive hash of query text
[2025-02-02 21:16:02,174][PID:1][INFO][alembic.runtime.migration] Running upgrade 1038c2174f5d -> 7ce5925f832b, create sqlalchemy_searchable expressions
[2025-02-02 21:16:02,180][PID:1][INFO][alembic.runtime.migration] Running upgrade 7ce5925f832b -> 7205816877ec, change type of json fields from varchar to json
[2025-02-02 21:16:15,184][PID:1][INFO][alembic.runtime.migration] Running upgrade 7205816877ec -> 9e8c841d1a30, fix_hash
Updating hash for query 1335 from 8966644fc83cbd9126877a13c7318e40 to 8966644fc83cbd9126877a13c7318e40
...
Query 1712 has parameters. Hash might be incorrect.
Updating hash for query 1712 from 9354cd4f49764d2bc155ebe7eba5b4e3 to 642169a69a80482959adaaf32c00ed48
Traceback (most recent call last):
  File "/app/manage.py", line 9, in <module>
    manager()
  File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.10/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/click/decorators.py", line 26, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/flask/cli.py", line 357, in decorator
    return __ctx.invoke(f, *args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/flask_migrate/cli.py", line 134, in upgrade
    _upgrade(directory, revision, sql, tag, x_arg)
  File "/usr/local/lib/python3.10/site-packages/flask_migrate/__init__.py", line 95, in wrapped
    f(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/flask_migrate/__init__.py", line 280, in upgrade
    command.upgrade(config, revision, sql=sql, tag=tag)
  File "/usr/local/lib/python3.10/site-packages/alembic/command.py", line 403, in upgrade
    script.run_env()
  File "/usr/local/lib/python3.10/site-packages/alembic/script/base.py", line 583, in run_env
    util.load_python_file(self.dir, "env.py")
  File "/usr/local/lib/python3.10/site-packages/alembic/util/pyfiles.py", line 95, in load_python_file
    module = load_module_py(module_id, path)
  File "/usr/local/lib/python3.10/site-packages/alembic/util/pyfiles.py", line 113, in load_module_py
    spec.loader.exec_module(module)  # type: ignore
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/app/migrations/env.py", line 93, in <module>
    run_migrations_online()
  File "/app/migrations/env.py", line 85, in run_migrations_online
    context.run_migrations()
  File "<string>", line 8, in run_migrations
  File "/usr/local/lib/python3.10/site-packages/alembic/runtime/environment.py", line 948, in run_migrations
    self.get_context().run_migrations(**kw)
  File "/usr/local/lib/python3.10/site-packages/alembic/runtime/migration.py", line 627, in run_migrations
    step.migration_fn(**kw)
  File "/app/migrations/versions/9e8c841d1a30_fix_hash.py", line 55, in upgrade
    new_hash = update_query_hash(record)
  File "/app/migrations/versions/9e8c841d1a30_fix_hash.py", line 33, in update_query_hash
    return query_runner.gen_query_hash(query_text, should_apply_auto_limit)
  File "/app/redash/query_runner/__init__.py", line 265, in gen_query_hash
    query_text = self.apply_auto_limit(query_text, set_auto_limit)
  File "/app/redash/query_runner/__init__.py", line 325, in apply_auto_limit
    if self.query_is_select_no_limit(last_query):
  File "/app/redash/query_runner/__init__.py", line 291, in query_is_select_no_limit
    parsed_query = sqlparse.parse(query)[0]
IndexError: tuple index out of range

Technical details:

• Redash Version: 25.1.0
• Browser/OS: Chrome/macOS
• How did you install Redash: Docker

[Ali-Bashir]

@cynicaljoy That's the same issue I am facing right now. But nothing worked for now. Did you find any solution?

[cynicaljoy]

@cynicaljoy That's the same issue I am facing right now. But nothing worked for now. Did you find any solution?

I did not, I'd suggest adding a 👍 to the issue to help the maintainers assess if this should be prioritized.

[snickerjp]

@cynicaljoy

Subject: Request for Confirmation Regarding Redash Query Data

Hello,

I would like to ask for your help in investigating the queries table in Redash.

What I Would Like You to Check

1. Could you check for records in the queries table where query is NULL or an empty string ('')?
   • Example:

     SELECT COUNT(*) FROM queries WHERE query IS NULL;
     SELECT COUNT(*) FROM queries WHERE query = '';

Reference Information

If Redash is running in a Docker environment, you can connect to PostgreSQL using the following steps:

cd /opt/redash
docker compose exec postgres sh
su - postgres
psql

I would really appreciate it if you could take a look.
Thank you in advance!

[cynicaljoy]

@Ali-Bashir are you able to take point on ☝? I'm actually not using Redash anymore.