Require Git 1.8.3

Author: unknwon

.travis.yml

@@ -10,6 +10,7 @@ go:
   - 1.10.x
   - 1.11.x
   - 1.12.x
+  - 1.13.x
 
 script: 
   - go get golang.org/x/tools/cmd/cover

README.md

@@ -5,7 +5,7 @@ Package git-module is a Go module for Git access through shell commands.
 ## Limitations
 
 - Go version must be at least **1.4**.
-- Git version must be no less than **1.7.1**, and greater than or equal to **1.8.3** is recommended.
+- Git version must be no less than **1.8.3**.
 - For Windows users, try use as new a version as possible.
 
 ## License

commit.go

@@ -13,8 +13,6 @@ import (
 	"net/http"
 	"strconv"
 	"strings"
-
-	goversion "github.com/mcuadros/go-version"
 )
 
 // Commit represents a git commit.
@@ -140,14 +138,7 @@ func CommitChanges(repoPath string, opts CommitChangesOptions) error {
 
 func commitsCount(repoPath, revision, relpath string) (int64, error) {
 	var cmd *Command
-	isFallback := false
-	if goversion.Compare(gitVersion, "1.8.0", "<") {
-		isFallback = true
-		cmd = NewCommand("log", "--pretty=format:''")
-	} else {
-		cmd = NewCommand("rev-list", "--count")
-	}
-	cmd.AddArguments(revision)
+	cmd = NewCommand("rev-list", "--count").AddArguments(revision)
 	if len(relpath) > 0 {
 		cmd.AddArguments("--", relpath)
 	}
@@ -157,9 +148,6 @@ func commitsCount(repoPath, revision, relpath string) (int64, error) {
 		return 0, err
 	}
 
-	if isFallback {
-		return int64(strings.Count(stdout, "\n")) + 1, nil
-	}
 	return strconv.ParseInt(strings.TrimSpace(stdout), 10, 64)
 }
 

git.go

@@ -10,12 +10,6 @@ import (
 	"time"
 )
 
-const version = "0.8.1"
-
-func Version() string {
-	return version
-}
-
 var (
 	// Debug enables verbose logging on everything.
 	// This should be false in case Gogs starts in SSH mode.

repo_branch.go

@@ -7,8 +7,6 @@ package git
 import (
 	"fmt"
 	"strings"
-
-	goversion "github.com/mcuadros/go-version"
 )
 
 const BranchPrefix = "refs/heads/"
@@ -54,10 +52,6 @@ func (repo *Repository) GetHEADBranch() (*Branch, error) {
 
 // SetDefaultBranch sets default branch of repository.
 func (repo *Repository) SetDefaultBranch(name string) error {
-	if goversion.Compare(gitVersion, "1.7.10", "<") {
-		return ErrUnsupportedVersion{"1.7.10"}
-	}
-
 	_, err := NewCommand("symbolic-ref", "HEAD", BranchPrefix+name).RunInDir(repo.Path)
 	return err
 }

repo_commit.go

@@ -11,8 +11,6 @@ import (
 	"strconv"
 	"strings"
 	"time"
-
-	goversion "github.com/mcuadros/go-version"
 )
 
 const RemotePrefix = "refs/remotes/"
@@ -257,37 +255,11 @@ func (repo *Repository) FilesCountBetween(startCommitID, endCommitID string) (in
 
 // CommitsBetween returns a list that contains commits between [last, before).
 func (repo *Repository) CommitsBetween(last *Commit, before *Commit) (*list.List, error) {
-	if goversion.Compare(gitVersion, "1.8.0", ">=") {
-		stdout, err := NewCommand("rev-list", before.ID.String()+"..."+last.ID.String()).RunInDirBytes(repo.Path)
-		if err != nil {
-			return nil, err
-		}
-		return repo.parsePrettyFormatLogToList(bytes.TrimSpace(stdout))
-	}
-
-	// Fallback to stupid solution, which iterates all commits of the repository
-	// if before is not an ancestor of last.
-	l := list.New()
-	if last == nil || last.ParentCount() == 0 {
-		return l, nil
-	}
-
-	var err error
-	cur := last
-	for {
-		if cur.ID.Equal(before.ID) {
-			break
-		}
-		l.PushBack(cur)
-		if cur.ParentCount() == 0 {
-			break
-		}
-		cur, err = cur.Parent(0)
-		if err != nil {
-			return nil, err
-		}
+	stdout, err := NewCommand("rev-list", before.ID.String()+"..."+last.ID.String()).RunInDirBytes(repo.Path)
+	if err != nil {
+		return nil, err
 	}
-	return l, nil
+	return repo.parsePrettyFormatLogToList(bytes.TrimSpace(stdout))
 }
 
 func (repo *Repository) CommitsBetweenIDs(last, before string) (*list.List, error) {