all: run staticcheck (#41)

* all: run staticcheck

* ci: fix install step

Author: unknwon

.travis.yml

@@ -1,9 +1,6 @@
 sudo: false
 language: go
 go:
-  - 1.4.x
-  - 1.5.x
-  - 1.6.x
   - 1.7.x
   - 1.8.x
   - 1.9.x
@@ -12,6 +9,7 @@ go:
   - 1.12.x
   - 1.13.x
 
+install: go get -v ./...
 script: 
   - go get golang.org/x/tools/cmd/cover
   - go get github.com/smartystreets/goconvey

Makefile

@@ -0,0 +1,13 @@
+.PHONY: vet test bench coverage
+
+vet:
+	go vet
+
+test:
+	go test -v -cover -race
+
+bench:
+	go test -v -cover -race -test.bench=. -test.benchmem
+
+coverage:
+	go test -coverprofile=c.out && go tool cover -html=c.out && rm c.out

README.md

@@ -6,7 +6,7 @@ Package git-module is a Go module for Git access through shell commands.
 
 ## Limitations
 
-- Go version must be at least **1.4**.
+- Go version must be at least **1.7**.
 - Git version must be no less than **1.8.3**.
 - For Windows users, try use as new a version as possible.
 

commit.go

@@ -67,7 +67,7 @@ func (c *Commit) ParentCount() int {
 
 func isImageFile(data []byte) (string, bool) {
 	contentType := http.DetectContentType(data)
-	if strings.Index(contentType, "image/") != -1 {
+	if strings.Contains(contentType, "image/") {
 		return contentType, true
 	}
 	return contentType, false
@@ -137,8 +137,7 @@ func CommitChanges(repoPath string, opts CommitChangesOptions) error {
 }
 
 func commitsCount(repoPath, revision, relpath string) (int64, error) {
-	var cmd *Command
-	cmd = NewCommand("rev-list", "--count").AddArguments(revision)
+	cmd := NewCommand("rev-list", "--count").AddArguments(revision)
 	if len(relpath) > 0 {
 		cmd.AddArguments("--", relpath)
 	}

repo.go

@@ -57,10 +57,7 @@ func IsRepoURLAccessible(opts NetworkOptions) bool {
 		opts.Timeout = -1
 	}
 	_, err := cmd.RunTimeout(opts.Timeout)
-	if err != nil {
-		return false
-	}
-	return true
+	return err == nil
 }
 
 // InitRepository initializes a new Git repository.

sha1.go

@@ -67,7 +67,7 @@ func MustID(b []byte) sha1 {
 // NewID creates a new sha1 from a [20]byte array.
 func NewID(b []byte) (sha1, error) {
 	if len(b) != 20 {
-		return sha1{}, fmt.Errorf("Length must be 20: %v", b)
+		return sha1{}, fmt.Errorf("length must be 20: %v", b)
 	}
 	return MustID(b), nil
 }
@@ -83,7 +83,7 @@ func NewIDFromString(s string) (sha1, error) {
 	var id sha1
 	s = strings.TrimSpace(s)
 	if len(s) != 40 {
-		return id, fmt.Errorf("Length must be 40: %s", s)
+		return id, fmt.Errorf("length must be 40: %s", s)
 	}
 	b, err := hex.DecodeString(s)
 	if err != nil {

tree.go

@@ -39,8 +39,7 @@ var (
 
 // UnescapeChars reverses escaped characters.
 func UnescapeChars(in []byte) []byte {
-	// LEGACY [Go 1.7]: use more expressive bytes.ContainsAny
-	if bytes.IndexAny(in, "\\\t") == -1 {
+	if bytes.ContainsAny(in, "\\\t") {
 		return in
 	}
 

tree_entry.go

@@ -35,8 +35,6 @@ type TreeEntry struct {
 
 	ptree *Tree
 
-	commited bool
-
 	size  int64
 	sized bool
 }