Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid port default for scheme=http #123

Closed
pyhedgehog opened this issue Feb 10, 2017 · 1 comment · Fixed by #125
Closed

Invalid port default for scheme=http #123

pyhedgehog opened this issue Feb 10, 2017 · 1 comment · Fixed by #125
Assignees
@guyzmo
Labels
bug

Comments

@pyhedgehog
Copy link
Contributor

port default should depends on scheme value as in buld_url(). It can just default to None for buld_url() to work correctly.
@guyzmo
Copy link
Owner

guyzmo commented Feb 10, 2017

yup you're right, I've been stupid here ☺

@guyzmo guyzmo self-assigned this Feb 10, 2017
guyzmo added a commit that referenced this issue Feb 10, 2017
@guyzmo
🚒 makes port default to 80 when scheme is HTTP
33db79a 
fixes #123

Signed-off-by: Guyzmo <guyzmo+github+pub@m0g.net>
@guyzmo guyzmo mentioned this issue Feb 10, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guyzmo guyzmo

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🚒 makes port default to 80 when scheme is HTTP guyzmo/git-repo
2 participants
@guyzmo @pyhedgehog