Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow running git repo commands from sub directories in the repository #188

Merged
merged 2 commits into from
Feb 3, 2018

Conversation

Crazybus
Copy link
Collaborator

This pull request allows you to use git-repo from any sub directory just like you can with the vanilla git client.

Before

❯ git hub request fetch 187
Successfully fetched request id `187` of `guyzmo/git-repo` into `requests/github/187`!
❯ cd git_repo/services
❯ git hub request fetch 187
Fatal error: Cannot find path to the repository.

After

❯ git hub request fetch 187
Successfully fetched request id `187` of `guyzmo/git-repo` into `requests/github/187`!
❯ cd git_repo/services
❯ git hub request fetch 187 
Successfully fetched request id `187` of `guyzmo/git-repo` into `requests/github/187`!

Git client behavior

❯ git status
On branch yellow_submarine
nothing to commit, working tree clean
❯ cd git_repo/services
❯ git status
On branch yellow_submarine
nothing to commit, working tree clean

@Crazybus Crazybus requested a review from guyzmo January 12, 2018 06:54
@guyzmo
Copy link
Owner

guyzmo commented Jan 17, 2018

Hello @Crazybus this is really awesome you did that ! ♥

I'm really snowed under by work, but I promise as soon as I get two seconds, I'll review this, as well as the gerrit PR.

@Crazybus
Copy link
Collaborator Author

@guyzmo Aren't we all :) Take your time and I hope things get a bit less hectic for you soon! I'm not in a rush since I'm using this version locally of course :P

Copy link
Owner

@guyzmo guyzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so far, so good 👍

It's simple, it's tested, it's working! Nothing to say 😉

I'll ship that one along with the gerrit request for the next release.

@guyzmo guyzmo merged commit f14a343 into guyzmo:devel Feb 3, 2018
@Crazybus Crazybus deleted the yellow_submarine branch February 5, 2018 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants