TFECO-9157: Add tests for identity_data.go and switch to multiple field reader
#1453
+694
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansgarm
force-pushed
the
test-identity-data-go
branch
from
55bb270 to
2c11511
Compare
This resembles the behaviour in `ResourceData` more closely. Specifically, this makes it possible to have number values in the source identity sent by Terraform that are encoded as strings. Before this commit this failed as the field writer does not allow to write strings for fields that are typed as integers in the schema, which is what we did to initialize the result.
ansgarm
force-pushed
the
test-identity-data-go
branch
from
06cf479 to
5eeaa23
Compare
ansgarm
changed the title
identity_data.goidentity_data.go and switch to multiple field reader
ansgarm
changed the title
identity_data.go and switch to multiple field readeridentity_data.go and switch to multiple field reader
austinvalle
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for
identity_data.goinspired by existing tests forresource_data.go.This uncovered a flaw in the current implementation, when it comes to non-string identity attributes which currently don't work.
To quote the relevant commit message on this: