Skip to content

Offering to copyedit entire tutorial #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmbothe opened this issue Aug 5, 2017 · 6 comments
Closed

Offering to copyedit entire tutorial #124

jmbothe opened this issue Aug 5, 2017 · 6 comments

Comments

@jmbothe
Copy link
Contributor

jmbothe commented Aug 5, 2017

@iliakan thanks for accepting my recent grammar/usage/punctuation pull request. If you'd like, I could review and edit the entire tutorial. With the little time I have available outside of work, I could probably complete the task in about four weeks. I just wanted to check with you to make sure this is something you are looking for, before I commit to the task. I suspect that this is something you'd be open to, considering the header on the tutorial pages explicitly requesting help with editing :)

I am a newbie coder just looking to get involved in a project somehow. As I mentioned in my pull request, my focus would only be grammar, word usage, and punctuation. I wouldn't be editing any sections of code (unless I was very confident an error existed), and I wouldn't seek to edit any of the text's style or meaning.

Let me know what you think. Cheers!

@iliakan
Copy link
Member

iliakan commented Aug 5, 2017

@jmbothe that'd be great, feel free to suggest changes that improve readability as well.
I'll review all changes to make sure they are technically correct.

Please make PRs as you go, don't smack me with one huge 4-week PR.

@jmbothe
Copy link
Contributor Author

jmbothe commented Aug 5, 2017

Cool! Thanks for the opportunity. A question about PR size/frequency: what is the ideal size of a PR, and how often could I submit? For example, my last PR included three articles. Should PR request be smaller? Could they be larger?

To meet my goal of finishing in one month, I would have to edit about four articles a day. So that would be one PR per day with four articles, or three PRs per week with twelve articles each, or one PR per week with twenty eight articles... you get the idea. Of course that's assuming that there will be edits for each article, which might not be the case. If that's too much I could also extend the timeline to six weeks or two months.

@iliakan
Copy link
Member

iliakan commented Aug 6, 2017

Per-article PR seems sane.

@iliakan
Copy link
Member

iliakan commented Aug 6, 2017

P.S. When I read the tutorial myself, I always see many places where I could say the same in more elegant and interesting way (or just right) and fix those I can reach.

@iliakan
Copy link
Member

iliakan commented Aug 28, 2017

@jmbothe could you please look at the two new PRs from @gwooly?

I have many doubts about them, and not enough proficiency to decide if the changes are correct.

@iliakan
Copy link
Member

iliakan commented Sep 15, 2017

Closing, as nothing is being done AFAIK. Thank you guys!

@iliakan iliakan closed this as completed Sep 15, 2017
athena0304 pushed a commit to athena0304/javascript-tutorial-en that referenced this issue Aug 21, 2018
* Update article.md

* Update article.md

* Update task.md

* Update solution.md

* Update task.md

* Update task.md

* Update solution.md

* Update task.md

* Update task.md

* Update task.md

* Update article.md

感谢校对

* Update task.md

* Update article.md

* Update task.md

* Update task.md

* Update article.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants