Skip to content

Request Korean distribution #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Violet-Bora-Lee opened this issue Nov 10, 2019 · 33 comments
Closed

Request Korean distribution #1602

Violet-Bora-Lee opened this issue Nov 10, 2019 · 33 comments

Comments

@Violet-Bora-Lee
Copy link
Member

Hello, Ilya and the Team!

The modern JavaScript tutorial in Korean is almost ready to publish(Part 1 is translated, almost), finally! 👍 👍 👍
#1149

Please let me know what I need to do to publish the Korean ver.
@iliakan
Copy link
Member

iliakan commented Nov 10, 2019

Great news! Mentioning @javascript-tutorial/translate-ko =)

Makes sense to translate site UI then.

Please clone https://github.com/javascript-tutorial/server, find all en.yml and put translated ko.yml alongside them, similar to other languages that you'll see there.

Then make a PR with this change.

P.S. ./edit ko ko runs the tutorial with Korean language files.

@Violet-Bora-Lee
Copy link
Member Author

I've made 2 PR on engine and server repositories.

javascript-tutorial/engine#26
javascript-tutorial/server#48

@iliakan
Copy link
Member

iliakan commented Nov 11, 2019

A few more phrases please:

terms: terms of usage
last_updated_at: "Last updated at #{date}"
contributors_pluralize: "contributor,contributors,contributors"

// search
articles: Articles of the tutorial
tasks: Tasks
results: Search results
search: Search
find: Find

shown_only_results: "Only first #{count} results are shown."

not_found:
  prefix: Sorry, we couldn't find anything
  articles: in the articles of the tutorial
  tasks: in the tasks

@iliakan
Copy link
Member

iliakan commented Nov 11, 2019

just post them here =) thank you!

@Violet-Bora-Lee
Copy link
Member Author 

terms: 이용 약관
last_updated_at: "최종 업데이트 #{date}"
contributors_pluralize: "contributor,contributors,contributors"

// search
articles: 글
tasks: 과제
results: 검색 결과
search: 검색
find: 찾기

shown_only_results: "#{count} 개의 검색 결과만 보기"

not_found:
  prefix: 죄송합니다.
  articles: 원하는 글을 찾지 못했습니다.
  tasks: 원하는 과제를 찾지 못했습니다.

@iliakan
Copy link
Member

iliakan commented Nov 11, 2019

contributors_pluralize: "contributor,contributors,contributors" . ?

@Violet-Bora-Lee
Copy link
Member Author 

terms: 이용 약관
last_updated_at: "최종 업데이트 #{date}"
contributors_pluralize: "기여자,기여자,기여자"

// search
articles: 글
tasks: 과제
results: 검색 결과
search: 검색
find: 찾기

shown_only_results: "#{count} 개의 검색 결과만 보기"

not_found:
  prefix: 죄송합니다.
  articles: 원하는 글을 찾지 못했습니다.
  tasks: 원하는 과제를 찾지 못했습니다.

@Violet-Bora-Lee
Copy link
Member Author

I couldn't see what these strings mean so I didn't translate.
I've just directly translated.

@iliakan
Copy link
Member

iliakan commented Nov 11, 2019 •
edited
Loading

Improved the text a bit, please translate the update:

- If you have suggestions what to improve - please <a href="https://github.com/javascript-tutorial/en.javascript.info/issues/new">submit a GitHub issue</a> or a pull request instead of commenting.
- If you can't understand something in the article – please elaborate.
- To insert a few words of code, use the <code>&lt;code&gt;</code> tag, for several lines – use <code>&lt;pre&gt;</code>, for more than 10 lines – use a sandbox (<a href='https://plnkr.co/edit/?p=preview'>plnkr</a>, <a href='http://jsbin.com'>JSBin</a>, <a href='http://codepen.io'>codepen</a>…)

@Violet-Bora-Lee
Copy link
Member Author

I have already translated using the above-mentioned sentences. ;)

@Violet-Bora-Lee
Copy link
Member Author

server/locales/ko.yml

  comment:
    help:
    - 추가 코멘트, 질문 및 답변을 자유롭게 남겨주세요. 개선해야 할 것이 있다면 댓글 대신 <a href='https://github.com/javascript-tutorial/en.javascript.info/issues/new'>이슈를 만들어주세요</a>.
    You're welcome to post additions, questions to the articles and answers to them.
    - 댓글에 몇 단어로 구성된 코드를 삽입하고 싶다면 <code>&lt;code&gt;</code> 태그를, 여러 줄로 구성된 코드를 삽입하고 싶다면 <code>&lt;pre&gt;</code> 태그를 이용하세요. 10줄 이상의 코드는 <a href='http://plnkr.co/edit/?p=preview'>plnkr</a>, <a href='http://jsbin.com'>JSBin</a>, <a href='http://codepen.io'>codepen</a> 등의 샌드박스를 사용하세요.
    - 잘 이해되지 않는 부분은 구체적으로 언급해주세요.

@iliakan
Copy link
Member

iliakan commented Nov 11, 2019

Please compare this with what I posted above.

The text is different.

@Violet-Bora-Lee
Copy link
Member Author

/done :)

- 개선해야 할 것이 있다면 댓글 대신 <a href='https://github.com/javascript-tutorial/en.javascript.info/issues/new'>이슈를 생성</a>하거나 Pull Request를 해주세요.
- 잘 이해되지 않는 부분을 알려주세요.
- 댓글에 몇 단어로 구성된 코드를 삽입하고 싶다면 <code>&lt;code&gt;</code> 태그를, 여러 줄로 구성된 코드를 삽입하고 싶다면 <code>&lt;pre&gt;</code> 태그를 이용하세요. 10줄 이상의 코드는 <a href='http://plnkr.co/edit/?p=preview'>plnkr</a>, <a href='http://jsbin.com'>JSBin</a>, <a href='http://codepen.io'>codepen</a> 등의 샌드박스를 사용해 추가할 수 있습니다.

@iliakan
Copy link
Member

iliakan commented Nov 11, 2019 •
edited
Loading

Awesome!

Just letting you know: we're almost ready to deploy, tweaking ElasticSearch to support Korean. It requires an upgrade and changes in config settings.

P.S. "Korean" is "한국어", right?

@Violet-Bora-Lee
Copy link
Member Author

Yes yes :)

@iliakan
Copy link
Member

iliakan commented Nov 14, 2019

@Violet-Bora-Lee Please take a look: https://ko.javascript.info/

Let me know if something needs fixing!

@Violet-Bora-Lee
Copy link
Member Author

It's working well :)

@Violet-Bora-Lee
Copy link
Member Author

Btw what about Disqus? It's not working but do you have plans to enabling it?

@Violet-Bora-Lee
Copy link
Member Author

Can i know yout person email address? Mine is learnerbr@gmail.com
I have things to ask

@iliakan
Copy link
Member

iliakan commented Nov 14, 2019

Sure, it's iliakan@gmail.com

@iliakan
Copy link
Member

iliakan commented Nov 14, 2019

Disqus is active now, thanks. There's no Korean locale in it, so its interface is in English.

@Violet-Bora-Lee
Copy link
Member Author

I've checked Disque is working. Can I get notifications when there are activities on Disqus?

@iliakan
Copy link
Member

iliakan commented Nov 14, 2019

There's the "Subscribe" button at the bottom-left corner:

image

I guess it subscribes for this exactly page.

P.S. Please review the content. Sometimes headers are accidentally not translated, even if the content is.
P.P.S. I think, when ready, we can tweet about the release or publish at some Korean resource and then read the feedback there :)

@Violet-Bora-Lee
Copy link
Member Author

Hello Ilya and the Team :)
It's been busy days. Sorry for the late reply.

  • I'll review the heading contents as you said.

  • There are some articles need to be reviewed again in Part 1. After that let's promote through the social network. I'm promoting a Korean tutorial to a few people to get honest reviews nowadays(kinda beta reviews). I'll let you know when I'm ready. Thanks as always. You and the Team are awesome(of course I'm too lol)

@Violet-Bora-Lee
Copy link
Member Author

Violet-Bora-Lee commented Nov 16, 2019 •
edited
Loading

Screenshot_20191116-214729_Chrome

And could you look at this UI bug?

@iliakan
Copy link
Member

iliakan commented Nov 16, 2019

Oh, that appeared, because I removed EPUB/PDF tutorial selling button.

Does it make sense to sell it in Korea?

@Violet-Bora-Lee
Copy link
Member Author

Yes i think it makes sense. But need to be reviewed again. And many of tasks are not translated yet. I want to publish this tutorial in tangible book. Wanna try with me?

@iliakan
Copy link
Member

iliakan commented Nov 16, 2019 •
edited
Loading

For ebook, please translate this:

build_at: Built at
last_version: The last version of the tutorial is at <a href="#{url}">#{url}</a>
tracker_ref: We constantly work to improve the tutorial. If you find any mistakes, please write at <a href="#{url}/issues/new">our github</a>
tasks: Tasks
importance: importance
to_solution: To solution
solutions: Solutions
to_formulation: To formulation
more: Additional series

newOrder:
  title: Buy EPUB/PDF for offline reading
  sample: Download sample
  translate_notification: "<b>NOTE</b>: #{progress}% of info is translated to English. We'll send you the full translated book update for free as soon as it’s ready."
  choose_course: Which parts of the tutorial you want?
  price: Price
  specifyEmail: Specify your email
  note: The download link will be sent to this address after payment.
  choose_payment: Select the payment method, please
  continue: Continue
  continue_text: By pressing the button 'Continue' you agree to our <a href="/terms">terms</a> and <a href="/privacy">privacy policy</a>.
  confirmation: Confirmation
  currency: USD
  continue_with_paypal: Pay with PayPal
  continue_with_stripe: Pay via Stripe
  continue_pay: Proceed with payment
  info: >
    <p><strong>PDF/EPUB</strong> book is an offline version of the tutorial. Buying this book, you support the project and become able to read the tutorial as e-book.</p>
    <p>You get the whole content as of now, plus 1 year of free updates.</p>

orders:
  order: Order
  failed: Payment failed, please try again later.
  currency: $
  payment: Payment
  successful: Successful
  pending: Confirmation pending
  amount: Price
  choose_another_payment: Choose another payment method
  do_not_pay_twice: Do not pay twice. Change payment method only if you are sure that payment failed.
  questions: If you have any questions please send them to
  thanks: Payment successful, thanks for your purchase!
  download: Download ebook
  confirmation_soon: "The confirmation was sent to <b>#{email}</b>"
  download_now: "You can download the tutorial right now using this link:"
  link_active_3_months: The link will be active for 1 year.
client:
  enter_email: Enter email.
onPaid:
  subject: JavaScript Tutorial EPUB/PDF

And also titles of the book.

ui.pdf
more.pdf
js.pdf

P.S. @Violet-Bora-Lee as you're the main translator, you'll get
50% of the ebook sales (price minus ± 10% of taxes/commissions). There won't be a lot while the audience is small (actually, no idea how much Koreans will support us like that).

P.P.S. Tangible is possible, but probably without tasks, as they take a lot of space.

@Violet-Bora-Lee
Copy link
Member Author

Violet-Bora-Lee commented Nov 17, 2019 •
edited
Loading

How much Koreans will support us will depend on the Korean tutorial's quality. I'm sure I'm maintaining the quality high :) But It's already published online for free so the sales depend on me and the marketing. Let's work together and watch.

I'll let you know when part 1 is ready.

@Violet-Bora-Lee
Copy link
Member Author

Hello, Ilya and the Team!

I'm promoting the Korean site nowadays.

btw, the translated contents are not updated on the site such as this https://github.com/javascript-tutorial/ko.javascript.info/blob/master/1-js/12-generators-iterators/2-async-iterators-generators/article.md

Could you check?

@iliakan
Copy link
Member

iliakan commented Dec 1, 2019 •
edited
Loading

Right, the hook was not set up. I added it.
I've run the build now.

Please let me know whether it works for future commits :)

@iliakan
Copy link
Member

iliakan commented Dec 2, 2019

Btw, that problem with the header on mobiles must have been fixed.

@iliakan
Copy link
Member

iliakan commented Dec 2, 2019

Closing this issue, as it's resolved.

@iliakan iliakan closed this as completed Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iliakan @Violet-Bora-Lee