Skip to content

Optional dark theme #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vitaly-zdanevich opened this issue Dec 18, 2017 · 15 comments
Open

Optional dark theme #339

vitaly-zdanevich opened this issue Dec 18, 2017 · 15 comments

Comments

@vitaly-zdanevich
Copy link

Many users like it, many users need it because of sensitive eyes, bad displays, low light conditions. This is called accessibility.

Also, MDN is white only - so dark theme will be your competitive adventure :)

@iliakan
Copy link
Member

iliakan commented Dec 20, 2017

Would be funny to have it, what you think, @Bezart ?

@nick-walt
Copy link

What about starting with enabling users to toggle the code example blocks between light (default?) and dark? I like the code blocks and a dark option might be an easy ehnancement.

The next potential feature is allowing the viewer to select a theme option from a few of the most common themes used for code presentation.

@vitaly-zdanevich
Copy link
Author

Just FYI - using extension for browser that invert colors:

screen shot 2017-12-26 at 9 22 06 am

@iliakan
Copy link
Member

iliakan commented Dec 26, 2017

@vitaly-zdanevich what you think about the extension, good enough? :)

@vitaly-zdanevich
Copy link
Author

Native is always better :)

@spacewasabi
Copy link

spacewasabi commented May 30, 2018

Maybe this isn't the place for what I have to say (as this discussion is getting old) but I'll say it anyway, just in case.

@vitaly-zdanevich Thanks for sharing this extension but imo Stylus is a little bit more interesting in our case. It allow users to use custom CSS on webpages.

If we're going for the accessibility debate, I think dark theme is just one of the elements we should consider, text-size, contrast and many more can come in handy for people with bad eye-sight (like me) or let's say color-blind people (like a friend of mine).

@vivekvpatil8888
Copy link

I think dark theme will give this website a popularity boost because many new learners like me are using this site daily and we want it to be in dark which is easy on eyes in night.

@originalmk
Copy link

No doubt, adding dark theme will be great option for night-readers.

@Bezart
Copy link
Collaborator

Bezart commented Dec 30, 2018

@iliakan I was thinking about creating a dark theme for tutorial pages only, however illustrations might look weird on dark background. Another point is inline examples that have separate css. To cover these 2 parts will require a lot of manual work. Of course we can leave theme as they are, but it will look ugly. What are your thoughts on this?

@iliakan
Copy link
Member

iliakan commented Dec 30, 2018

What are your thoughts about this, guys?

@Bezart asks about pictures, here are some of them (made in Sketch editor, Mac only, figures.sketch in the tutorial repo):

image

@maurodibert
Copy link
Contributor

maurodibert commented Jun 13, 2019

Hi people! I came here in order to create an issue and start reading this and thought it was an awesome idea. Is still dark mode a thing to develop? I also think as @SugoiNelson that could be just 'the tip of the iceberg' but could be an amazing place to start with.

@scott-ln scott-ln mentioned this issue Sep 4, 2019
@dagolinuxoid
Copy link
Contributor

I'm skeptical about it:

  1. The current light theme is looking decent.
  2. The dark theme actually isn't that good for your eyes.
  3. It's hard to make polished dark theme. Honestly speaking a lot of dark themes out there are just crigny, if someone considering of making it at some point you're better put in the work. It's easy to ruin the platform by introducing a sloppy dark theme.

@vitaly-zdanevich
Copy link
Author

In the meanwhile was introduced https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme

@Ali-Hussein-dev
Copy link

I use an extension that gives me great control over brightness, contrast and more. it is called "dark reader". it is a great alternative to even native themes.
Screenshot_2020-01-14 Class basic syntax

@sanket-bhalerao
Copy link

*** careful while using the flags settings on the browser, this can have serious consequences if not done carefully ***
if you are using a chromium-based browser you can try the following workaround.

go to the flags using the applicable link

chrome: `chrome://flags/#enable-force-dark`
brave:`brave://flags/#enable-force-dark`
edge:`edge://flags/#enable-force-dark`
  1. change the flag from default to enabled
  2. relaunch the browser

this will turn every site accessed on the browser to dark mode. I would suggest having a secondary browser for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests