-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Optional dark theme #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Would be funny to have it, what you think, @Bezart ? |
What about starting with enabling users to toggle the code example blocks between light (default?) and dark? I like the code blocks and a dark option might be an easy ehnancement. The next potential feature is allowing the viewer to select a theme option from a few of the most common themes used for code presentation. |
Just FYI - using extension for browser that invert colors: |
@vitaly-zdanevich what you think about the extension, good enough? :) |
Native is always better :) |
Maybe this isn't the place for what I have to say (as this discussion is getting old) but I'll say it anyway, just in case. @vitaly-zdanevich Thanks for sharing this extension but imo Stylus is a little bit more interesting in our case. It allow users to use custom CSS on webpages. If we're going for the accessibility debate, I think dark theme is just one of the elements we should consider, text-size, contrast and many more can come in handy for people with bad eye-sight (like me) or let's say color-blind people (like a friend of mine). |
I think dark theme will give this website a popularity boost because many new learners like me are using this site daily and we want it to be in dark which is easy on eyes in night. |
No doubt, adding dark theme will be great option for night-readers. |
@iliakan I was thinking about creating a dark theme for tutorial pages only, however illustrations might look weird on dark background. Another point is inline examples that have separate css. To cover these 2 parts will require a lot of manual work. Of course we can leave theme as they are, but it will look ugly. What are your thoughts on this? |
What are your thoughts about this, guys? @Bezart asks about pictures, here are some of them (made in Sketch editor, Mac only, |
Hi people! I came here in order to create an issue and start reading this and thought it was an awesome idea. Is still dark mode a thing to develop? I also think as @SugoiNelson that could be just 'the tip of the iceberg' but could be an amazing place to start with. |
I'm skeptical about it:
|
In the meanwhile was introduced https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme |
*** careful while using the flags settings on the browser, this can have serious consequences if not done carefully *** go to the flags using the applicable link
this will turn every site accessed on the browser to dark mode. I would suggest having a secondary browser for this. |
Many users like it, many users need it because of sensitive eyes, bad displays, low light conditions. This is called accessibility.
Also, MDN is white only - so dark theme will be your competitive adventure :)
The text was updated successfully, but these errors were encountered: