Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Contribution Guide #18

Closed
8 tasks
ashokdey opened this issue Oct 3, 2019 · 1 comment
Closed
8 tasks

Add Contribution Guide #18

ashokdey opened this issue Oct 3, 2019 · 1 comment
Assignees
Labels

Comments

@ashokdey
Copy link
Member

ashokdey commented Oct 3, 2019

What do we need in the Contribution Guide?

  • When adding a new problem with solution

    • Take care of the filename convention (Very Important)
    • Problem statement should be there with examples
    • Make sure you add the Run Time complexity of your solution
    • Please take care of the segregation of the Problems as per the given Folder Structure
    • It's great if you can add the Unit Tests to verify your solutions as well
    • Strictly follow ESLINT rules
  • When adding a Unit Test

    • Take care of the file name convention
    • Make sure CI (Travis) is passing
@ashokdey
Copy link
Member Author

ashokdey commented Oct 5, 2019

This Guide closes this issue.

@ashokdey ashokdey closed this as completed Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants