Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Unit Test for - Caeser Cipher #40

Closed
TheSTL opened this issue Oct 7, 2019 · 7 comments
Closed

Add Unit Test for - Caeser Cipher #40

TheSTL opened this issue Oct 7, 2019 · 7 comments
Labels
claimed-already Someone else is already working on this good first issue Good for newcomers

Comments

@TheSTL
Copy link
Member

TheSTL commented Oct 7, 2019 •
edited
Loading

🤡 What is required?

The algorithm is here : Caeser Cipher

  • Follow the ESLint rules strictly
  • Follow the filename and folder structure strictly
  • Since the Contribution Guide is not ready yet, go through the codebase pattern and add tests accordingly

Thank You!
@fcosueza
Copy link

fcosueza commented Oct 7, 2019

I can work on this. 👍

@ashokdey
Copy link
Member

ashokdey commented Oct 7, 2019

Sure @fcosueza, I have assigned this issue to you.

@ashokdey ashokdey added the claimed-already Someone else is already working on this label Oct 7, 2019
@fcosueza
Copy link

fcosueza commented Oct 7, 2019

Thanks !! 😃

@fcosueza
Copy link

fcosueza commented Oct 7, 2019 •
edited
Loading

Caesar cipher should raise and error when second argument is not a number, instead it's returning a string of "undefinedundefinedundefined". Also, the folder is misspelled "caeser". Should i correct it or make a new issue ?

@TheSTL
Copy link
Member Author

TheSTL commented Oct 7, 2019

@fcosueza
You should make a new issue for this and correct it in a new PR.

@ashokdey ashokdey mentioned this issue Oct 7, 2019
Closed
@Omkaragrawal
Copy link

Hey,
I would like to take this task.

@ashokdey
Copy link
Member

ashokdey commented Oct 8, 2019

Hey,
I would like to take this task.

Hey, @Omkaragrawal I have assigned you the fix and you can continue from there.

@Omkaragrawal Omkaragrawal mentioned this issue Oct 8, 2019
Closed
@fcosueza fcosueza removed their assignment Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
claimed-already Someone else is already working on this good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Caesar cipher [Fixed #40] [Fixed #44] Omkaragrawal/problem-solving-javascript
4 participants
@fcosueza @ashokdey @Omkaragrawal @TheSTL