Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Unit Test for - Get Smallest Common Number #47

Closed
TheSTL opened this issue Oct 8, 2019 · 2 comments
Closed

Add Unit Test for - Get Smallest Common Number #47

TheSTL opened this issue Oct 8, 2019 · 2 comments
Assignees
@dwncy
Labels
beginner friendly good first issue Good for newcomers

Comments

@TheSTL
Copy link
Member

TheSTL commented Oct 8, 2019

👽 What is required?

The algorithm is here : get-smallest-common-number

  • Follow the ESLint rules strictly
  • Follow the filename and folder structure strictly
  • Since the Contribution Guide is not ready yet, go through the codebase pattern and add tests accordingly

Thank You!
@TheSTL TheSTL changed the title Get-Smallest-Common-Number Add Unit Test for -Get-Smallest-Common-Number Oct 8, 2019
@TheSTL TheSTL changed the title Add Unit Test for -Get-Smallest-Common-Number Add Unit Test for - Get Smallest Common Number Oct 8, 2019
@dwncy
Copy link

dwncy commented Oct 8, 2019

Hi, I would like to take this :)

@dwncy dwncy mentioned this issue Oct 8, 2019
Merged
@TheSTL
Copy link
Member Author

TheSTL commented Oct 10, 2019

I'am closing this issue.
PR for this issue - #50

@TheSTL TheSTL closed this as completed Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dwncy dwncy

Labels
beginner friendly good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dwncy @TheSTL