Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview file displays strange chars #22

Closed
williamdes opened this issue Sep 8, 2024 · 9 comments · Fixed by #31
Closed

Preview file displays strange chars #22

williamdes opened this issue Sep 8, 2024 · 9 comments · Fixed by #31
Labels
bug Something isn't working question Further information is requested

Comments

@williamdes
Copy link

williamdes commented Sep 8, 2024 •
edited
Loading

image

Received: from dc18.wdes.intranet (unknown [10.10.18.120])
	(using TLSv1.3 with cipher TLS13_AES_256_GCM_SHA384)
	by mx2.mails.wdes.eu (Stalwart SMTP) with ESMTPS id 29EA16FB9A12202;
	Mon, 29 Jul 2024 22:01:56 +0000
Authentication-Results: mx2.mails.wdes.eu;
	spf=none (mx2.mails.wdes.eu: no SPF records found for postmaster@dc18.wdes.intranet) smtp.helo=dc18.wdes.intranet;
	spf=none (mx2.mails.wdes.eu: no SPF records found for pve@proxmox.dc18.wdes.intranet) smtp.mailfrom=pve@proxmox.dc18.wdes.intranet;
	iprev=permerror (dns record not found) policy.iprev=10.10.18.120;
	dmarc=none header.from=proxmox.dc18.wdes.intranet policy.dmarc=none
Received-SPF: none (mx2.mails.wdes.eu: no SPF records found for pve@proxmox.dc18.wdes.intranet)
	receiver=mx2.mails.wdes.eu; client-ip=10.10.18.120; envelope-from="pve@proxmox.dc18.wdes.intranet"; helo=dc18.wdes.intranet;
X-Spam-Status: Yes, score=5.518642402045409
X-Spam-Result: MID_RHS_MATCH_FROMTLD (1),
	TO_MATCH_ENVRCPT_ALL (0),
	RBL_SENDERSCORE (2),
	FROM_EQ_ENVFROM (0),
	TO_DN_NONE (0),
	TAGGED_RCPT (0),
	SPF_NA (0),
	HELO_NORES_A_OR_MX (0.3),
	RCVD_TLS_LAST (0),
	FROM_NO_DN (0),
	RCVD_COUNT_ONE (0),
	URIBL_BLOCKED (0),
	ARC_NA (0),
	DKIM_NA (0),
	RCPT_COUNT_ONE (0),
	RDNS_NONE (1),
	AUTH_NA (1),
	DMARC_NA (0),
	FROMHOST_NORES_A_OR_MX (1.5)
Return-Path: <pve@proxmox.dc18.wdes.intranet>
Received: by dc18.wdes.intranet (Postfix, from userid 0)
	id 83C7227A3C; Tue, 30 Jul 2024 00:00:41 +0200 (CEST)
From: pve@proxmox.dc18.wdes.intranet
To: tech+dc18@wdes.eu
Subject: Cron <root@pve-dc18> pve-autosnap all 2 --exclude=10001,10002 --tag=DAILY
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Cron-Env: <MAILTO=tech+proxmox-cron@wdes.eu>
X-Cron-Env: <MAILFROM=tech+dc18-proxmox@wdes.eu>

Maybe tabs create such display bugs ?
Terminal: Guake and XFCE terminal.
@lusingander
Copy link
Owner

At least when I uploaded the attached text, I didn't have any problems.

Similarly, if you re-upload it (by copying the code block), does the same problem occur?
If it does, it could be a problem with your terminal environment, etc. If not, it's likely a problem with the original text file.

Maybe tabs create such display bugs ?

Tabs are replaced with spaces (because the library doesn't handle them well), so it seems unlikely that this is the cause.

@lusingander lusingander added the question Further information is requested label Sep 9, 2024
@lusingander
Copy link
Owner

lusingander commented Sep 11, 2024 •
edited
Loading

It seems that a similar problem may occur when opening binary files etc. It may be that some binary sequence, including tabs, is causing the problem.

@lusingander lusingander added the bug Something isn't working label Sep 11, 2024
@williamdes
Copy link
Author

It seems that a similar problem may occur when opening binary files etc. It may be that some binary sequence, including tabs, is causing the problem.

Well, it is a pure text file as attached but the mime is declared as binary

@williamdes
Copy link
Author

The actual content type of my objects is application/octet-stream

@lusingander
Copy link
Owner

📝

v0.5.0: Seems to be displayed correctly
v0.5.1: Not correct

During these releases, the ratatui version was updated to 0.27.0.
v0.5.0...v0.5.1

@lusingander lusingander mentioned this issue Sep 21, 2024
Merged
@lusingander
Copy link
Owner

#31 fixed the problem, at least for me. If you still have any problems, please let me know.

@lusingander
Copy link
Owner

https://github.com/lusingander/stu/releases/tag/v0.6.3

@williamdes
Copy link
Author

https://github.com/lusingander/stu/releases/tag/v0.6.3

The display works fine now, thank you !

@lusingander
Copy link
Owner

That's good to hear!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the handling of control characters in text preview lusingander/stu
2 participants
@williamdes @lusingander