Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy report #556

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

m-kovalsky
Copy link
Collaborator

No description provided.

@a-holm
Copy link

a-holm commented Mar 30, 2025

LGTM! This PR adds a useful deploy_report function, which looks like a great addition for managing report lifecycles. The refactoring of clone_report to use standardized helpers and support UUIDs is also a good improvement.

A couple of minor points to make it easier for the people who review PRs here:

  1. Consider adding a brief description to the PR explaining the motivation and summarizing the changes.
  2. In _report_functions.py, the docstring for clone_report could explicitly mention that it will not overwrite an existing report and will issue a warning instead. This clarifies the intended behavior compared to deploy_report.

Overall, nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants