Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Hounsfield scale for transfer functions #217

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

mlavik1
Copy link
Owner

@mlavik1 mlavik1 commented Oct 16, 2023

Changes:

  • Transfer function now use absolute data values by default.
  • When applying old TFs to a volume, we convert to absolute values on the fly.
  • Added a new transfer function upgrader tool window, for upgrading old TFs.

Details:

Currently there's a big limitation related to the transfer functions: They use relative data values (relative to the min/max data values of a dataset), and the same TF can therefore not be applied to different transfer functions. In practice we often deal with datasets that use the same (Hounsfield) scale, such as DICOM and NRRD. So this has become a limitation for many users.

It was implemented like this long before DICOM support was added. The idea was to have TFs that can work across different scales (we only supported RAW datasets in the beginning, and they can often have very different scales). However, we should be able to support both by specifying the scale in the saved TF.

TODO:

  • Add a "use relative scale" checkbox to the TF editor???
  • Support 2D transfer functions?

@mlavik1 mlavik1 marked this pull request as ready for review October 16, 2023 17:29
@mlavik1
Copy link
Owner Author

mlavik1 commented Oct 16, 2023

TF upgrader tool:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant