Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Losing required properties of rules #16

Closed
WinterSilence opened this issue Mar 8, 2020 · 5 comments
Closed

Losing required properties of rules #16

WinterSilence opened this issue Mar 8, 2020 · 5 comments

Comments

@WinterSilence
Copy link

As example: rule header_comment added as: 'header_comment' => ['comment_type'=>'PHPDoc'], and dont contain required property header.

@mlocati
Copy link
Owner

mlocati commented Mar 9, 2020

Are they lost?
Using the example of the header property of the header_comment fixer, do you mean that you configure header with https://mlocati.github.io/php-cs-fixer-configurator and when you export the configuration you don't have the header property?

@WinterSilence
Copy link
Author

@mlocati exported the configuration don't have the header attribute

@WinterSilence
Copy link
Author

@mlocati by default this attribute not existed in array, i'm think need add HTML attr required to inputs like this

@WinterSilence
Copy link
Author

WinterSilence commented Mar 11, 2020

@mlocati if you add header_comment without optional confuguration:

<?php
return PhpCsFixer\Config::create()
    ->setRules([
        'header_comment' => true,
    ])

@mlocati
Copy link
Owner

mlocati commented Jun 22, 2020

This is working for me:

header-option-value

@mlocati mlocati closed this as completed Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants