|
1 | 1 | # How to contribute
|
2 | 2 |
|
3 |
| -We love receiving pull requests. We use them ourselves for reviewing new features and fixing issues in modm. |
4 |
| -If you want to contribute, but don't exactly know what or how, have a look at the [issues we tagged with "help wanted"][help_wanted]. |
| 3 | +We love receiving pull requests. We use them ourselves for reviewing new features |
| 4 | +and fixing issues in modm. If you want to contribute, but don't exactly know what |
| 5 | +or how, have a look at the [issues we tagged with "help wanted"][help_wanted]. |
| 6 | + |
| 7 | +To start contributing, please fork modm and then start a new branch on top of |
| 8 | +the `develop` branch. We prefer to fast-forward merges, instead of creating a |
| 9 | +merge commit, so your contributions must be up-to-date with develop. |
5 | 10 |
|
6 |
| -To start contributing, please fork modm and then start a new branch on top of the `develop` branch. |
7 | 11 | We recommend prefixing your branch with
|
8 | 12 | - `feature/` for new functionality, or
|
9 | 13 | - `fix/` for a bug fix.
|
10 | 14 |
|
11 | 15 | Please remember to have a look at [our coding conventions](docs/coding_convention.md).
|
12 | 16 |
|
13 |
| -Once you [open the pull request][pulls], we will review it and might ask you for changes. |
14 |
| -Remember that you can continue to push to your `feature/*` or `fix/*` branches to update the corresponding pull requests! |
| 17 | +Once you [open the pull request][pulls], we will review it and might ask you for |
| 18 | +changes. Remember that you can continue to push to your `feature/*` or `fix/*` |
| 19 | +branches to update the corresponding pull requests! |
| 20 | + |
| 21 | +Including unit tests is very welcomed and highly recommended. modm has its own |
| 22 | +simple and easy to use unit test framework. Unit tests are placed in the `modm/test` |
| 23 | +subdirectory. [See testing strategies in modm](docs/TESTING.md). |
15 | 24 |
|
16 |
| -Including unit tests is very welcomed and highly recommended. modm has its own simple and easy to use unit test framework. Unit tests are placed in the `test` subdirectory (e.g. `test/modm/math/filter`) and are run with `make test-{hosted|stm32|avr}`. [See here for more information about testing strategies in modm](docs/TESTING.md). |
| 25 | +The CI first compiles all examples and unittests and then executes the unittests |
| 26 | +for Linux. If all of that passes, it will compile all `:platform:**` modules for |
| 27 | +all supported devices. Please note that your pull request will have to pass ALL |
| 28 | +CI tests in order to be merged. |
17 | 29 |
|
18 |
| -The CI first compiles all examples and unittests and then executes the unittests for Linux. |
19 |
| -If all of that passes, it will compile all `:platform:**` modules for all supported devices. |
20 |
| -Please note that your pull request will have to pass ALL CI tests in order to be merged. |
21 | 30 |
|
22 | 31 | ## When in doubt, ask
|
23 | 32 |
|
24 |
| -The dedicated maintainer of modm is [@salkinium](https://github.com/salkinium) and you can always ping him. |
| 33 | +The dedicated maintainer of modm is [@salkinium](https://github.com/salkinium) |
| 34 | +and you can always ping him. |
25 | 35 |
|
26 |
| -If you want to add a new platform, or other significant functionality, we [ask you to discuss that in an issue first][issues]. We are very open to new helping hands, but all of this is still fairly complicated and we want to provide you with tips and additional explanations along the way. |
| 36 | +If you want to add a new platform, or other significant functionality, we |
| 37 | +[ask you to discuss that in an issue first][issues]. We are very open to new |
| 38 | +helping hands, but all of this is still fairly complicated and we want to |
| 39 | +provideyou with tips and additional explanations along the way. |
27 | 40 |
|
28 |
| -Communication is cheap, implementation is expensive and we don't want to frustrate you. |
| 41 | +Communication is cheap, implementation is expensive and we don't want to |
| 42 | +frustrate you. |
29 | 43 |
|
30 | 44 | [issues]: https://github.com/modm-io/modm/issues
|
31 | 45 | [pulls]: https://github.com/modm-io/modm/pulls
|
32 |
| -[help_wanted]: https://github.com/modm-io/modm/issues?q=is%3Aissue+is%3Aopen+label%3A%22help+wanted%22 |
| 46 | +[help_wanted]: https://github.com/modm-io/modm/issues?q=is%3Aissue+is%3Aopen+label%3A%22help+wanted+🛠%22 |
0 commit comments