Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modmail internal cleanup #150

Merged
merged 78 commits into from
Jan 28, 2019
Merged

Modmail internal cleanup #150

merged 78 commits into from
Jan 28, 2019
+2,892 −1,406

Conversation

Taaku18
Copy link
Collaborator

@Taaku18 Taaku18 commented Jan 23, 2019 •
edited by kyb3r
Loading

Fixes #133 and Resolves #157

Working In Progress.

  • PEP 8 Conventions (100%)
  • Line spacing, line width readability (100%)
  • Type hinting and type annotations (100%)
  • Rename mispelt and unclear variables (98%)
  • Resolve style TODO's in code (95%)
  • Rewrite awkward code syntaxes (95%)
  • Reorganize code definitions and imports
  • Doc-strings

Doc strings and reorganization had been moved to a separate branch, to be merged upon completion.

Afterwards:

  • A Lot More Testing

1 0 Pending issues

Upon shutting down bot: (Seems to be only a problem on MacOS caused by discord.py)

Unclosed client session
client_session: <aiohttp.client.ClientSession object at 0x10d8f2438>
Unclosed connector
connections: ['[(<aiohttp.client_proto.ResponseHandler object at 0x10ddd1d68>, 8035.16)]']
connector: <aiohttp.connector.TCPConnector object at 0x10d8f2208>

Total progress so far:

⬛⬛⬛⬛⬛⬛⬛⬛⬛⬛⬛⬛⬛⬛⬛⬛⬛⬛⬛⬜ 95%

Sorry, something went wrong.

Taaku18 added 30 commits January 16, 2019 21:47
@Taaku18
Preliminary round of cleanup in bot.py
4090e5b
@Taaku18
Preliminary round of cleanup in time.py
39efba4
@Taaku18
Preliminary round of cleanup in thread.py
a5c4aa8
@Taaku18
Preliminary round of cleanup in paginator.py

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
c74d278
@Taaku18
Preliminary round of cleanup in decorators.py

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
ed326e0
@Taaku18
Preliminary round of cleanup in clients.py
68ac68e
@Taaku18
Preliminary round of cleanup in changelog.py
4e2a637
@Taaku18
Import reduction in core
97a2f92
@Taaku18
Stle adjusting in bot.py and core/*
6631775
@Taaku18
Preliminary round of cleanup in modmail.py
10a5535
@Taaku18
Preliminary round of cleanup in utility.py
9d85053
@Taaku18
Reorganize imports
de28f65
@Taaku18
Merge branch 'umaster' into cleanup
bc99682
@Taaku18
Type Annotations
e13dbf7
@Taaku18
Merge from branch "master"
5d93d2e
@Taaku18
Manual merge from master, freezes packages in requirements.txt
e82f25b
@Taaku18
Merge from "master"
88a2957
@Taaku18
Merge from "master"
70aeffd
@Taaku18
Merge branch 'master' into cleanup
4f09774
@Taaku18
Fixed a bug in type hinting
742bb23
@Taaku18
Fixed bug in note command
f15a959
@Taaku18
Implement get_prefix which replaces the former weird get_pre method
2077e33
@Taaku18
Change all reference of to
64e99b0 
As deemed by all modern dictionary, self-hosted is two words seperated by a hyphen
@Taaku18
Fixed bug where config del wasn't working
7e66294
@Taaku18
Correct typo
a87604b
@Taaku18
Merge from "master"
6e9e223
@Taaku18
Merge from "master"
ef2b3fe
@Taaku18
Merge branch 'master' into cleanup
8bd5788
@Taaku18
format
ae7abcb
@Taaku18
Merge from "master" and removed fieldinator(?) from help
af62d84
@kyb3r kyb3r temporarily deployed to cgrokmodmail January 28, 2019 03:40 Inactive
@kyb3r kyb3r temporarily deployed to cgrokmodmail January 28, 2019 09:34 Inactive
@kyb3r kyb3r temporarily deployed to cgrokmodmail January 28, 2019 10:23 Inactive
@kyb3r kyb3r temporarily deployed to cgrokmodmail January 28, 2019 10:38 Inactive
@kyb3r kyb3r temporarily deployed to cgrokmodmail January 28, 2019 10:56 Inactive
@kyb3r kyb3r temporarily deployed to cgrokmodmail January 28, 2019 11:04 Inactive
@kyb3r kyb3r temporarily deployed to cgrokmodmail January 28, 2019 11:14 Inactive
@kyb3r kyb3r temporarily deployed to cgrokmodmail January 28, 2019 11:19 Inactive
@kyb3r kyb3r temporarily deployed to cgrokmodmail January 28, 2019 11:27 Inactive
@kyb3r kyb3r temporarily deployed to cgrokmodmail January 28, 2019 11:28 Inactive
@kyb3r kyb3r merged commit 33880ac into master Jan 28, 2019
@Taaku18 Taaku18 deleted the cleanup branch January 29, 2019 01:01
@Taaku18 Taaku18 changed the title [WIP] Modmail internal cleanup Modmail internal cleanup Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyb3r kyb3r

Assignees

@Taaku18 Taaku18

Labels
help wanted pending review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expand ?logs command with search queries Improving our coding conventions
2 participants
@Taaku18 @kyb3r