-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multiple environment support and cleanup #11
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request enhances the project's environment configuration management by introducing support for multiple environments, improving error handling, and updating the project setup process. The changes focus on replacing the dotenv library with dotenvx, implementing a more user-friendly error display for environment variable validation, and updating the README with new instructions for environment setup. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hassancodess - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟡 Security: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
resolution: {integrity: sha512-IchNf6dN4tHoMFIn/7OE8LWZ19Y6q/67Bmf6vnGREv8RSbBVb9LPJxEcnwrcwX6ixSvaiGoomAUvu4YSxXrVgw==} | ||
engines: {node: '>=12'} | ||
|
||
'@dotenvx/dotenvx@1.14.0': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 suggestion (security): Review usage and security implications of new dependencies
New dependencies like '@dotenvx/dotenvx' and '@noble/ciphers' have been added. Ensure their usage aligns with project requirements and doesn't introduce security vulnerabilities.
This PR includes the following updates:
Summary by Sourcery
Add support for multiple environments by introducing .env.development and .env.production files, and update the README with relevant instructions. Replace dotenv with dotenvx for better environment variable management and improve error formatting for environment variable validation.
New Features:
Enhancements:
Documentation:
Chores: