Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outdated MathJax CDN links in scripts/visualization_tools.py #20

Closed
DrXyzzy opened this issue May 11, 2018 · 3 comments
Closed

outdated MathJax CDN links in scripts/visualization_tools.py #20

DrXyzzy opened this issue May 11, 2018 · 3 comments
Assignees

Comments

@DrXyzzy
Copy link

DrXyzzy commented May 11, 2018

Two links to MathJax in scripts/visualization_tools.py

src="http://cdn.mathjax.org/mathjax/latest/MathJax.js?config=TeX-AMS-MML_HTMLorMML">

should probably be updated. See MathJax CDN shutting down on April 30, 2017. . You could replace with e.g.

src="https://cdnjs.cloudflare.com/ajax/libs/mathjax/2.7.1/MathJax.js?config=TeX-AMS-MML_HTMLorMML">

This affects display of e.g., graphdebug.html during install steps in Google Chrome. There's an example at this walkthrough of ccg2lambda install in CoCalc.

@pasmargo pasmargo self-assigned this May 14, 2018
@pasmargo
Copy link
Contributor

I was not aware of MathJax CDN shutting down. Thank you very much for the update!
I have changed the links following your suggestion. However, I don't have Google Chrome at hand to test it.
Please let us know if the problem has been fixed (it works correctly for Firefox and Chromium).
Thank you again!

By the way: the CoCalc walkthrough is quite cool. I have learned quite a few things. Thanks!

@DrXyzzy
Copy link
Author

DrXyzzy commented May 14, 2018

I tested the new code in Google Chrome and Chrome now displays the diagram without patching graphdebug.html. Thank you!

@pasmargo
Copy link
Contributor

Thank you very much for testing it on Google Chrome. That is very much appreciated!
I will close the issue then.
Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants