Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add rate limit zone sync docs #7481

Merged
merged 4 commits into from
Mar 25, 2025
Merged

add rate limit zone sync docs #7481

merged 4 commits into from
Mar 25, 2025

Conversation

AlexFenlon
Copy link
Contributor

@AlexFenlon AlexFenlon commented Mar 6, 2025 •
edited
Loading

Proposed changes

  • Update docs to account for updated functionality of rate limit scale and zone-sync

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Mar 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/7481/

AlexFenlon added a commit that referenced this pull request Mar 6, 2025
@AlexFenlon
pull docs into seperate pr (#7481)
3b71976
@AlexFenlon AlexFenlon linked an issue Mar 6, 2025 that may be closed by this pull request
Ensure zone_sync takes priority over scale setting for RateLimit policy #7398
Closed
3 tasks
@AlexFenlon AlexFenlon removed a link to an issue Mar 6, 2025
Ensure zone_sync takes priority over scale setting for RateLimit policy #7398
Closed
3 tasks
@AlexFenlon AlexFenlon marked this pull request as ready for review March 24, 2025 10:39
@AlexFenlon AlexFenlon requested review from a team as code owners March 24, 2025 10:39
@AlexFenlon AlexFenlon self-assigned this Mar 24, 2025
@ADubhlaoich ADubhlaoich added needs cherry pick Cherry pick this PR into a release branch and removed needs cherry pick Cherry pick this PR into a release branch labels Mar 24, 2025
@ADubhlaoich
Copy link
Contributor

Not sure if this needs to be cherry-picked or not.

@AlexFenlon
Copy link
Contributor Author

Not sure if this needs to be cherry-picked or not.

No cherry-pick needed, this will go into v4.1.0

@AlexFenlon AlexFenlon enabled auto-merge (squash) March 25, 2025 11:51
@AlexFenlon AlexFenlon merged commit abd5a38 into main Mar 25, 2025
30 checks passed
@AlexFenlon AlexFenlon deleted the docs/rate-limit-zone-sync-scale branch March 25, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADubhlaoich ADubhlaoich

@JTorreG JTorreG

@jjngx jjngx

Assignees

@AlexFenlon AlexFenlon

Labels
documentation Pull requests/issues for documentation
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexFenlon @ADubhlaoich @JTorreG @jjngx