Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SNI support for JWT secrets retrieved from HTTPS URL #7500

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

fabriziofiorucci
Copy link
Contributor

Proposed changes

The current NGINX Ingress Controller implementation doesn't set the SNI field when fetching the JWT secret from an HTTPS URL. This breaks compatibility with idPs requiring SNI to be set.

This PR adds two directives to turn on SNI and set the hostname.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@fabriziofiorucci fabriziofiorucci requested a review from a team as a code owner March 12, 2025 13:59
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Mar 12, 2025
@shaun-nx shaun-nx linked an issue Mar 12, 2025 that may be closed by this pull request
Copy link
Contributor Author

@fabriziofiorucci fabriziofiorucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes reviewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SNI for JWT policy
1 participant