Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new directory for rofs #7519

Merged
merged 4 commits into from
Mar 25, 2025
Merged

Conversation

haywoodsh
Copy link
Contributor

@haywoodsh haywoodsh commented Mar 14, 2025

Proposed changes

Add emptyDir for the path /var/lib/nginx/state to the helm chart and manifest when using read-only file system. closes #7510 #7322

Validation

  1. Deploy NIC with read only file system enabled. Wait until usage report is sent

    2025/03/24 13:20:58 [info] 26#26: usage report was sent
    
  2. navigate to the file system of the NIC pod, the required directory /var/lib/nginx/state/ is present and the file nginx-mgmt-state has been created by NGINX without any errors.

    $ ls /var/lib/nginx/state/
    nginx-mgmt-state
    

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added bug An issue reporting a potential bug python Pull requests that update Python code tests Pull requests that update tests helm_chart Pull requests that update the Helm Chart labels Mar 14, 2025
@haywoodsh haywoodsh force-pushed the fix/create-emptydir-for-usage-reporting branch 3 times, most recently from 7e59051 to 5f20dc7 Compare March 24, 2025 13:24
@haywoodsh haywoodsh marked this pull request as ready for review March 24, 2025 13:25
@haywoodsh haywoodsh requested a review from a team as a code owner March 24, 2025 13:25
haywoodsh and others added 2 commits March 24, 2025 17:25
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
Co-authored-by: Venktesh Shivam Patel <ve.patel@f5.com>
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
@haywoodsh haywoodsh force-pushed the fix/create-emptydir-for-usage-reporting branch from 5f20dc7 to 7bed453 Compare March 24, 2025 17:25
@haywoodsh haywoodsh merged commit 12cf0fa into main Mar 25, 2025
30 checks passed
@haywoodsh haywoodsh deleted the fix/create-emptydir-for-usage-reporting branch March 25, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug helm_chart Pull requests that update the Helm Chart python Pull requests that update Python code tests Pull requests that update tests
Projects
None yet
4 participants