-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Outdated external zoxide completer #1845
Comments
We discussed this in the meeting yesterday, and we generally agree this is a good way forward. We would also really like to see spans being passed to internal completers, similar to how external completers work, rather than just a context string. I think we could also provide a completer (in the cookbook, or maybe in def "nu-complete external" [context: string] {
do $env.config.completions.external.completer ($context | split row " ")
}
# my cool ssh wrapper
def ssh [...rest: string@"nu-complete external"] {
^ssh ...$rest
}
ssh <TAB>
# auto-complete results from carapace, in my case |
Does that mean another breaking change, or something like splitting string into spans if the argument type is list instead of string?
That's cool, should I add that example to external_completer.md and link it to custom_completions.md? |
Some users reported that the config in https://www.nushell.sh/cookbook/external_completers.html#zoxide-completer
is no longer working in nu 0.103.
That is because I disabled external completer for arguments of internal commands in nushell/nushell#15086.
IMO, it's not a great idea to resort to the external completer for internals. If we can agree on that, that part of the documents need to be updated then. Maybe just delete that section, I'm not sure.
The text was updated successfully, but these errors were encountered: