Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc updates #9

Merged
merged 1 commit into from
Sep 26, 2024
Merged

misc updates #9

merged 1 commit into from
Sep 26, 2024

Conversation

olsonpm
Copy link
Owner

@olsonpm olsonpm commented Sep 26, 2024

fixes #8

  • bump version
  • fix windows bugs
    1. structured-cli used "app-root-path" which wasn't working properly in windows. So we updated structured-cli to remove that dependency
    2. use platform-independent node solution to read the first 16 bytes of the sqlite file to validate. Previously we called head which is a unix utility and broke on windows.
  • update dependencies
  • require node v16+
  • fix tests occurring on node v20
    : this mostly includes
    • awaiting requests
    • removing the connection header since keep-alive is the new default as of node 19
    • change the testing mechanism to containsSubset rather than deep equals which ignores extra headers we don't care about (in our case connection close vs keep-alive)

less important updates

  • fix package-lock.json
    : previously it was out of sync from package.json
  • rename vars
  • remove unused code
  • run prettier on all files
  • rename sqlite3 file constraints to isSqlite3File for better error reporting
  • remove leftover debug console.log statements

- bump version
- fix windows bugs
  1. structured-cli used "app-root-path" which wasn't working properly
     in windows.  So we updated structured-cli to remove that dependency
  2. use platform-independent node solution to read the first 16 bytes
     of the sqlite file to validate.  Previously we called `head` which
     is a unix utility and broke on windows.
- update dependencies
- require node v16+
- fix tests occurring on node v20
  : this mostly includes
    - awaiting requests
    - removing the connection header since keep-alive is the new default
      as of node 19
    - change the testing mechanism to containsSubset rather than deep
      equals - which ignores extra headers we don't care about
      (in our case connection close vs keep-alive)

less important updates
- fix package-lock.json
  : previously it was out of sync from package.json
- rename vars
- remove unused code
- run prettier on all files
- rename sqlite3 file constraints to isSqlite3File for better
  error reporting
- remove leftover debug console.log statements
@olsonpm olsonpm merged commit 326189c into dev Sep 26, 2024
@olsonpm olsonpm deleted the fix-windows branch September 26, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant