[Snippets] Fixed handling of Parameters with 1D shapes in SplitDimensionM pass
#29573
+28
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-sidorova
requested review from
v-Golubev and
aobolensk
and removed request for
a team
github-actions
bot
added
category: IE Tests
aobolensk
reviewed
Mar 20, 2025
Comment on lines
+220
to
+221
| // if Shape rank is less than index of dimension M, no need to reshape it. | ||
| if (shape.size() <= dim_M_index) |
There was a problem hiding this comment.
Comment and condition mismatch: shape rank is "less" or "less or equal"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Parameterswith 1D shapes inSplitDimensionMpass. No need to insertReshapeop on input with 1D shape sinceMdimension has index1from the end.Tickets: