Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GPU] not to apply EliminateScalarMul for scalar const less than 1 #29602

Merged
merged 1 commit into from
Mar 21, 2025
Merged

[GPU] not to apply EliminateScalarMul for scalar const less than 1 #29602

merged 1 commit into from
Mar 21, 2025

Conversation

e-ddykim
Copy link
Contributor

Details:

  • The EliminateScalarMul pass eliminates scalar multiplication layers before normalization layers. But
    • if 0 < activations scale factor < 1, epsilon value of normalization becomes large.
    • if activations scale factor < 0, the output of normalization layers is different.

Tickets:

  • 164333

@e-ddykim e-ddykim requested a review from a team as a code owner March 20, 2025 13:34
@e-ddykim e-ddykim requested review from itikhono and removed request for a team March 20, 2025 13:34
@github-actions github-actions bot added the category: transformations OpenVINO Runtime library - Transformations label Mar 20, 2025
@vladimir-paramuzov vladimir-paramuzov added this to the 2025.2 milestone Mar 21, 2025
@vladimir-paramuzov vladimir-paramuzov added this pull request to the merge queue Mar 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 21, 2025
@e-ddykim e-ddykim added this pull request to the merge queue Mar 21, 2025
Merged via the queue into openvinotoolkit:master with commit 7b1d059 Mar 21, 2025
185 checks passed
@e-ddykim e-ddykim deleted the act_scaling_fix branch March 21, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimir-paramuzov vladimir-paramuzov

@yeonbok yeonbok

@andrew-k-park andrew-k-park

@itikhono itikhono

Assignees
No one assigned
Labels
category: transformations OpenVINO Runtime library - Transformations
Projects
None yet
Milestone
2025.2
Development

Successfully merging this pull request may close these issues.
4 participants
@e-ddykim @vladimir-paramuzov @yeonbok @andrew-k-park