Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Dark Mode Feature #80

Closed
wants to merge 1 commit into from
Closed

Adding Dark Mode Feature #80

wants to merge 1 commit into from

Conversation

rickieleehao
Copy link

Dark Mode Feature allow the application to have a darker UI.

  • added a button with action listener
  • added a changeBGColor method

Dark Mode Feature allow the application to have a darker UI.

- added a button with action listener
- added a changeBGColor method
@pH-7
Copy link
Owner

pH-7 commented Aug 13, 2022

Great idea @rickieleehao! However, adding again another button for the dark mode doesn't really make sense here since it goes beyond the scope of the calculator. It would be nice then to enable the dark mode (like implemented) only if the OS has the dark mode enabled.

MAYBE... we could use something like https://github.com/Dansoftowner/jSystemThemeDetector ...

final OsThemeDetector detector = OsThemeDetector.getDetector();
final boolean isDarkThemeUsed = detector.isDark();
if (isDarkThemeUsed) {
    //The OS uses a dark theme
} else {
    //The OS uses a light theme
}

@rickieleehao
Copy link
Author

Thank you for your feedback! This is actually one of my current university assignment which we have to learn the workflow of how people contribute in open-source environment and attempt to make some contribution. Nevertheless, I appreciate to receive your reply and sorry for any inconveniences.

@pH-7
Copy link
Owner

pH-7 commented Aug 20, 2022

No worries @rickieleehao, that's all good 🙂 Are you still willing to complete your changes and get your PR merged with the given suggestion? If not, I will close it.

@rickieleehao rickieleehao closed this by deleting the head repository Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants