Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for testnets #12

Closed
litneet64 opened this issue Mar 8, 2021 · 3 comments
Closed

Add support for testnets #12

litneet64 opened this issue Mar 8, 2021 · 3 comments

Comments

@litneet64
Copy link

litneet64 commented Mar 8, 2021

Hi, I'm working on a project that relies on etherscan-python for communicating with Etherscan.io's API, and having support for querying stuff on the other testnets will come really handy for the end goal of it.

Luckily, I already added that feature on a fork I did from this project following the overall "minimalism" (as said on the description) and also adding the testnets to the module tests with their own working/stable test cases (randomly sampled - [*]) along with a minimalist usage example on the README.

[*] Unfortunately, I don't possess a PRO API key, so I couldn't find working test cases for the PRO endpoints nor I know if they are already passing with those parameters or not.

@github-actions
Copy link

github-actions bot commented Mar 8, 2021

Thanks for reporting this issue, we are on it :)

@litneet64
Copy link
Author

Also, logs for testnets are not included as I think their existence on this repo is a decision for you to take, however their proper generation is already found on the module tests' code.

@pcko1
Copy link
Owner

pcko1 commented Mar 31, 2021

@litneet64 apologies for the late reply, I somehow missed this notification. I have just accepted your PR! Unfortunately the pro methods are not supported for the test-nets by Etherscan.io but everything else seems to be working well. Thanks a lot for this contribution :)

@pcko1 pcko1 closed this as completed Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants