Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: petertodd/python-bitcoinlib
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: python-bitcoinlib-v0.12.2
Choose a base ref
...
head repository: petertodd/python-bitcoinlib
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 14 commits
  • 6 files changed
  • 6 contributors

Commits on Dec 8, 2023

  1. Update petertodd DNS seeds

    petertodd committed Dec 8, 2023
    Copy the full SHA
    173a73e View commit details

Commits on May 6, 2024

  1. Copy the full SHA
    2fabb36 View commit details

Commits on Jun 4, 2024

  1. core: support openssl 3

    In modern version of openssl (iirc from 1.1) the
    library `libeay32` is removed in favor of libcrypto.
    
    See for more info openssl/openssl#10332
    
    This commit is adding the possibility to include libcrypto too
    
    Fixing the following error on a nix shell
    
    /home/vincent/.cache/pypoetry/virtualenvs/lampo-lnprototest-IQvPSNpc-py3.11/lib/python3.11/site-packages/_pytest/config/__init__.py:325: PluggyTeardownRaisedWarning: A plugin raised an exception during an old-style hookwrapper teardown.
    Plugin: helpconfig, Hook: pytest_cmdline_parse
    ConftestImportFailure: OSError: libeay32: cannot open shared object file: No such file or directory (from /home/vincent/gittea/work/lampo.rs/tests/lnprototest/tests/conftest.py)
    For more information see https://pluggy.readthedocs.io/en/stable/api_reference.html#pluggy.PluggyTeardownRaisedWarning
      config = pluginmanager.hook.pytest_cmdline_parse(
    ImportError while loading conftest '/home/vincent/gittea/work/lampo.rs/tests/lnprototest/tests/conftest.py'.
    tests/conftest.py:3: in <module>
        import lnprototest
    /home/vincent/.cache/pypoetry/virtualenvs/lampo-lnprototest-IQvPSNpc-py3.11/lib/python3.11/site-packages/lnprototest/__init__.py:15: in <module>
        from .event import (
    /home/vincent/.cache/pypoetry/virtualenvs/lampo-lnprototest-IQvPSNpc-py3.11/lib/python3.11/site-packages/lnprototest/event.py:16: in <module>
        from .namespace import namespace
    /home/vincent/.cache/pypoetry/virtualenvs/lampo-lnprototest-IQvPSNpc-py3.11/lib/python3.11/site-packages/lnprototest/namespace.py:6: in <module>
        from .signature import SigType
    /home/vincent/.cache/pypoetry/virtualenvs/lampo-lnprototest-IQvPSNpc-py3.11/lib/python3.11/site-packages/lnprototest/signature.py:5: in <module>
        from .utils import check_hex, privkey_expand
    /home/vincent/.cache/pypoetry/virtualenvs/lampo-lnprototest-IQvPSNpc-py3.11/lib/python3.11/site-packages/lnprototest/utils/__init__.py:18: in <module>
        from .bitcoin_utils import (
    /home/vincent/.cache/pypoetry/virtualenvs/lampo-lnprototest-IQvPSNpc-py3.11/lib/python3.11/site-packages/lnprototest/utils/bitcoin_utils.py:14: in <module>
        from bitcoin.wallet import CBitcoinSecret
    /home/vincent/.cache/pypoetry/virtualenvs/lampo-lnprototest-IQvPSNpc-py3.11/lib/python3.11/site-packages/bitcoin/wallet.py:23: in <module>
        import bitcoin.core.key
    /home/vincent/.cache/pypoetry/virtualenvs/lampo-lnprototest-IQvPSNpc-py3.11/lib/python3.11/site-packages/bitcoin/core/key.py:27: in <module>
        _ssl = ctypes.cdll.LoadLibrary(
    /nix/store/sxr2igfkwhxbagri49b8krmcqz168sim-python3-3.11.8/lib/python3.11/ctypes/__init__.py:454: in LoadLibrary
        return self._dlltype(name)
    /nix/store/sxr2igfkwhxbagri49b8krmcqz168sim-python3-3.11.8/lib/python3.11/ctypes/__init__.py:376: in __init__
        self._handle = _dlopen(self._name, mode)
    E   OSError: libeay32: cannot open shared object file: No such file or directory
    make[1]: *** [Makefile:11: check] Error 4
    
    Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
    vincenzopalazzo committed Jun 4, 2024
    Copy the full SHA
    fc46e33 View commit details

Commits on Aug 6, 2024

  1. Merge #300: Add HTTPS to supported RPC Proxy protocols

    2fabb36 Add HTTPS to supported RPC Proxy protocols (mhh)
    
    Pull request description:
    
      Allows using HTTPS URLs when configuring a Bitcoin proxy:
      ```python
      import bitcoin.rpc
    
      btc_proxy = bitcoin.rpc.Proxy(
          service_url="https://<some-rpc-id>.btc.quiknode.pro/<api-secret>"
      )
      ```
    
    Top commit has no ACKs.
    
    Tree-SHA512: 190dd5ce30e4a31da81c5a06161739b10e34279458821fa0c4be952033d6aaf7a0380e3edecd49c6b9f0984f6d62488e9f5be1efe50f683bab5edca0c2d13752
    petertodd committed Aug 6, 2024
    Copy the full SHA
    101bde5 View commit details
  2. Merge #301: core: support openssl 3

    fc46e33 core: support openssl 3 (Vincenzo Palazzo)
    
    Pull request description:
    
      In modern version of openssl (iirc from 1.1) the
      library `libeay32` is removed in favour of libcrypto.
    
      See for more info openssl/openssl#10332
    
      This commit adds the possibility to include libcrypto too
    
      Fixing the following error on a nix shell
    
      ```
      /home/vincent/.cache/pypoetry/virtualenvs/lampo-lnprototest-IQvPSNpc-py3.11/lib/python3.11/site-packages/_pytest/config/__init__.py:325: PluggyTeardownRaisedWarning: A plugin raised an exception during an old-style hookwrapper teardown. Plugin: helpconfig, Hook: pytest_cmdline_parse
      ConftestImportFailure: OSError: libeay32: cannot open shared object file: No such file or directory (from /home/vincent/gittea/work/lampo.rs/tests/lnprototest/tests/conftest.py) For more information see https://pluggy.readthedocs.io/en/stable/api_reference.html#pluggy.PluggyTeardownRaisedWarning
        config = pluginmanager.hook.pytest_cmdline_parse(
      ImportError while loading conftest '/home/vincent/gittea/work/lampo.rs/tests/lnprototest/tests/conftest.py'.
      tests/conftest.py:3: in <module>
          import lnprototest
      /home/vincent/.cache/pypoetry/virtualenvs/lampo-lnprototest-IQvPSNpc-py3.11/lib/python3.11/site-packages/lnprototest/__init__.py:15: in <module>
          from .event import (
      /home/vincent/.cache/pypoetry/virtualenvs/lampo-lnprototest-IQvPSNpc-py3.11/lib/python3.11/site-packages/lnprototest/event.py:16: in <module>
          from .namespace import namespace
      /home/vincent/.cache/pypoetry/virtualenvs/lampo-lnprototest-IQvPSNpc-py3.11/lib/python3.11/site-packages/lnprototest/namespace.py:6: in <module>
          from .signature import SigType
      /home/vincent/.cache/pypoetry/virtualenvs/lampo-lnprototest-IQvPSNpc-py3.11/lib/python3.11/site-packages/lnprototest/signature.py:5: in <module>
          from .utils import check_hex, privkey_expand
      /home/vincent/.cache/pypoetry/virtualenvs/lampo-lnprototest-IQvPSNpc-py3.11/lib/python3.11/site-packages/lnprototest/utils/__init__.py:18: in <module>
          from .bitcoin_utils import (
      /home/vincent/.cache/pypoetry/virtualenvs/lampo-lnprototest-IQvPSNpc-py3.11/lib/python3.11/site-packages/lnprototest/utils/bitcoin_utils.py:14: in <module>
          from bitcoin.wallet import CBitcoinSecret
      /home/vincent/.cache/pypoetry/virtualenvs/lampo-lnprototest-IQvPSNpc-py3.11/lib/python3.11/site-packages/bitcoin/wallet.py:23: in <module>
          import bitcoin.core.key
      /home/vincent/.cache/pypoetry/virtualenvs/lampo-lnprototest-IQvPSNpc-py3.11/lib/python3.11/site-packages/bitcoin/core/key.py:27: in <module>
          _ssl = ctypes.cdll.LoadLibrary(
      /nix/store/sxr2igfkwhxbagri49b8krmcqz168sim-python3-3.11.8/lib/python3.11/ctypes/__init__.py:454: in LoadLibrary
          return self._dlltype(name)
      /nix/store/sxr2igfkwhxbagri49b8krmcqz168sim-python3-3.11.8/lib/python3.11/ctypes/__init__.py:376: in __init__
          self._handle = _dlopen(self._name, mode)
      E   OSError: libeay32: cannot open shared object file: No such file or directory
      make[1]: *** [Makefile:11: check] Error 4
      ```
    
    Top commit has no ACKs.
    
    Tree-SHA512: a42bad5f66de3c7da5884d00e6016525df41e263a8169bdac0d82b08ab7934575b46ccf985f6c844808989c6919c753fb874177eab99c22aa7b6f1ab77c90422
    petertodd committed Aug 6, 2024
    Copy the full SHA
    06e7289 View commit details

Commits on Oct 30, 2024

  1. core: Fix a bug with loading libcrypto

    Looks like the fix in #301 was not working.
    
    I got the following error while trying to run `from bitcoin.rpc import Proxy` on my machine
    
    ```
    File ~\OneDrive\Documents\GitHub\python-bitcoinlib\bitcoin\rpc.py:38
         36 from bitcoin.core import COIN, x, lx, b2lx, CBlock, CBlockHeader, CTransaction, COutPoint, CTxOut
         37 from bitcoin.core.script import CScript
    ---> 38 from bitcoin.wallet import CBitcoinAddress, CBitcoinSecret
         40 DEFAULT_USER_AGENT = "AuthServiceProxy/0.1"
         42 DEFAULT_HTTP_TIMEOUT = 30
    
    File ~\OneDrive\Documents\GitHub\python-bitcoinlib\bitcoin\wallet.py:23
         21 import bitcoin.bech32
         22 import bitcoin.core
    ---> 23 import bitcoin.core.key
         24 import bitcoin.core.script as script
         27 class CBitcoinAddress(object):
    
    File ~\OneDrive\Documents\GitHub\python-bitcoinlib\bitcoin\core\key.py:27
         23 import bitcoin.signature
         25 import bitcoin.core.script
    ---> 27 _ssl = ctypes.cdll.LoadLibrary(
         28     ctypes.util.find_library('ssl.35') or ctypes.util.find_library('ssl') or ctypes.util.find_library('libeay32')
         29     or ctypes.cdll.LoadLibrary("libcrypto")
         30 )
         32 _libsecp256k1_path = ctypes.util.find_library('secp256k1')
         33 _libsecp256k1_enable_signing = False
    
    File ~\.pyenv\pyenv-win\versions\3.12.7\Lib\ctypes\__init__.py:460, in LibraryLoader.LoadLibrary(self, name)
        459 def LoadLibrary(self, name):
    --> 460     return self._dlltype(name)
    
    File ~\.pyenv\pyenv-win\versions\3.12.7\Lib\ctypes\__init__.py:348, in CDLL.__init__(self, name, mode, handle, use_errno, use_last_error, winmode)
        343 def __init__(self, name, mode=DEFAULT_MODE, handle=None,
        344              use_errno=False,
        345              use_last_error=False,
        346              winmode=None):
        347     if name:
    --> 348         name = _os.fspath(name)
        349     self._name = name
        350     flags = self._func_flags_
    
    TypeError: expected str, bytes or os.PathLike object, not CDLL
    aviv57 committed Oct 30, 2024
    Copy the full SHA
    d2fe2ad View commit details

Commits on Nov 25, 2024

  1. add createwallet rpc command

    ZZiigguurraatt authored and ZZiigguurraatt committed Nov 25, 2024
    Copy the full SHA
    e5bedda View commit details
  2. add loadwallet rpc command

    ZZiigguurraatt authored and ZZiigguurraatt committed Nov 25, 2024
    Copy the full SHA
    65e8f15 View commit details

Commits on Dec 3, 2024

  1. Update serialize.py (Docstring Typo:)

    The closing parenthesis in the docstring should be removed.
    Gudnessuche authored Dec 3, 2024
    Copy the full SHA
    5c0ff08 View commit details

Commits on Mar 9, 2025

  1. Merge #308: Update serialize.py (Docstring Typo:)

    5c0ff08 Update serialize.py (Docstring Typo:) (Jesus Christ)
    
    Pull request description:
    
      The closing parenthesis in the docstring should be removed.
    
    Top commit has no ACKs.
    
    Tree-SHA512: 355fbdf3c98460ecb8b1302def97b42f7cc83317acb346905b3009be86435fff0a38269d1609c975e9315ad30c99e39b494c4c14d8744eccea931c9e073cba97
    petertodd committed Mar 9, 2025
    Copy the full SHA
    d288940 View commit details
  2. Merge #307: add createwallet rpc command

    65e8f15 add loadwallet rpc command (ZZiigguurraatt)
    e5bedda add createwallet rpc command (ZZiigguurraatt)
    
    Pull request description:
    
    Top commit has no ACKs.
    
    Tree-SHA512: 92d136ecb57b4866773242ee4728347e8e6f9f6c0952ce089c190acdf655e88d4d202f635c981f2b5b562c58e797c01a35742b1c224749a71d8d11c9a59768ad
    petertodd committed Mar 9, 2025
    Copy the full SHA
    384a8c2 View commit details
  3. Merge #306: core: Fix a bug with loading libcrypto

    d2fe2ad core: Fix a bug with loading libcrypto (aviv57)
    
    Pull request description:
    
      Looks like the fix in #301 was not working.
    
      I got the following error while trying to run `from bitcoin.rpc import Proxy` on my machine
    
      ```
      File ~\OneDrive\Documents\GitHub\python-bitcoinlib\bitcoin\rpc.py:38
           36 from bitcoin.core import COIN, x, lx, b2lx, CBlock, CBlockHeader, CTransaction, COutPoint, CTxOut
           37 from bitcoin.core.script import CScript
      ---> 38 from bitcoin.wallet import CBitcoinAddress, CBitcoinSecret
           40 DEFAULT_USER_AGENT = "AuthServiceProxy/0.1"
           42 DEFAULT_HTTP_TIMEOUT = 30
    
      File ~\OneDrive\Documents\GitHub\python-bitcoinlib\bitcoin\wallet.py:23
           21 import bitcoin.bech32
           22 import bitcoin.core
      ---> 23 import bitcoin.core.key
           24 import bitcoin.core.script as script
           27 class CBitcoinAddress(object):
    
      File ~\OneDrive\Documents\GitHub\python-bitcoinlib\bitcoin\core\key.py:27
           23 import bitcoin.signature
           25 import bitcoin.core.script
      ---> 27 _ssl = ctypes.cdll.LoadLibrary(
           28     ctypes.util.find_library('ssl.35') or ctypes.util.find_library('ssl') or ctypes.util.find_library('libeay32')
           29     or ctypes.cdll.LoadLibrary("libcrypto")
           30 )
           32 _libsecp256k1_path = ctypes.util.find_library('secp256k1')
           33 _libsecp256k1_enable_signing = False
    
      File ~\.pyenv\pyenv-win\versions\3.12.7\Lib\ctypes\__init__.py:460, in LibraryLoader.LoadLibrary(self, name)
          459 def LoadLibrary(self, name):
      --> 460     return self._dlltype(name)
    
      File ~\.pyenv\pyenv-win\versions\3.12.7\Lib\ctypes\__init__.py:348, in CDLL.__init__(self, name, mode, handle, use_errno, use_last_error, winmode)
          343 def __init__(self, name, mode=DEFAULT_MODE, handle=None,
          344              use_errno=False,
          345              use_last_error=False,
          346              winmode=None):
          347     if name:
      --> 348         name = _os.fspath(name)
          349     self._name = name
          350     flags = self._func_flags_
    
      TypeError: expected str, bytes or os.PathLike object, not CDLL
    
    Top commit has no ACKs.
    
    Tree-SHA512: afb98bb333a8011c9074d537277610dff1a72083f6f8128f8a83fbd61f30b923a70341ab005d8adc0b6f269a4ca91e14a6bf4bbb44f8b08a5b86625c9f847593
    petertodd committed Mar 9, 2025
    Copy the full SHA
    b269135 View commit details

Commits on Mar 14, 2025

  1. Create python-package.yml

    petertodd authored Mar 14, 2025
    Copy the full SHA
    5ca4485 View commit details
  2. Fix flake8 fail

    petertodd committed Mar 14, 2025
    Copy the full SHA
    91e334d View commit details

This comparison is taking too long to generate.

Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.

You can try running this command locally to see the comparison on your machine:
git diff python-bitcoinlib-v0.12.2...master