Skip to content

refactor(namespaces): renamed \Null to \NoEffect for future comp… #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions composer.json
Original file line number Diff line number Diff line change
@@ -88,6 +88,7 @@
"Enqueue\\Gps\\": "pkg/gps/",
"Enqueue\\JobQueue\\": "pkg/job-queue/",
"Enqueue\\Mongodb\\": "pkg/mongodb/",
"Enqueue\\NoEffect\\": "pkg/noeffect/",
"Enqueue\\Null\\": "pkg/null/",
"Enqueue\\Pheanstalk\\": "pkg/pheanstalk/",
"Enqueue\\RdKafka\\": "pkg/rdkafka/",
2 changes: 1 addition & 1 deletion docs/transport/null.md
Original file line number Diff line number Diff line change
@@ -25,7 +25,7 @@ $ composer require enqueue/null

```php
<?php
use Enqueue\Null\NullConnectionFactory;
use Enqueue\NoEffect\NullConnectionFactory;

$connectionFactory = new NullConnectionFactory();

2 changes: 1 addition & 1 deletion pkg/amqp-bunny/Tests/AmqpConsumerTest.php
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@
use Bunny\Message;
use Enqueue\AmqpBunny\AmqpConsumer;
use Enqueue\AmqpBunny\AmqpContext;
use Enqueue\Null\NullMessage;
use Enqueue\NoEffect\NullMessage;
use Enqueue\Test\ClassExtensionTrait;
use Enqueue\Test\WriteAttributeTrait;
use Interop\Amqp\Impl\AmqpMessage;
2 changes: 1 addition & 1 deletion pkg/amqp-bunny/composer.json
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@
"require-dev": {
"phpunit/phpunit": "^9.5",
"enqueue/test": "0.10.x-dev",
"enqueue/null": "0.10.x-dev",
"enqueue/noeffect": "0.10.x-dev",
"queue-interop/queue-spec": "^0.6.2"
},
"support": {
8 changes: 4 additions & 4 deletions pkg/amqp-ext/Tests/AmqpContextTest.php
Original file line number Diff line number Diff line change
@@ -6,8 +6,8 @@
use Enqueue\AmqpExt\AmqpContext;
use Enqueue\AmqpExt\AmqpProducer;
use Enqueue\AmqpExt\AmqpSubscriptionConsumer;
use Enqueue\Null\NullQueue;
use Enqueue\Null\NullTopic;
use Enqueue\NoEffect\NullQueue;
use Enqueue\NoEffect\NullTopic;
use Enqueue\Test\ClassExtensionTrait;
use Enqueue\Test\ReadAttributeTrait;
use Interop\Amqp\Impl\AmqpMessage;
@@ -124,7 +124,7 @@ public function testShouldThrowIfNotAmqpQueueGivenOnCreateConsumerCall()
$context = new AmqpContext($this->createExtChannelMock());

$this->expectException(InvalidDestinationException::class);
$this->expectExceptionMessage('The destination must be an instance of Interop\Amqp\AmqpQueue but got Enqueue\Null\NullQueue.');
$this->expectExceptionMessage('The destination must be an instance of Interop\Amqp\AmqpQueue but got Enqueue\NoEffect\NullQueue.');
$context->createConsumer(new NullQueue('aName'));
}

@@ -133,7 +133,7 @@ public function testShouldThrowIfNotAmqpTopicGivenOnCreateConsumerCall()
$context = new AmqpContext($this->createExtChannelMock());

$this->expectException(InvalidDestinationException::class);
$this->expectExceptionMessage('The destination must be an instance of Interop\Amqp\AmqpTopic but got Enqueue\Null\NullTopic.');
$this->expectExceptionMessage('The destination must be an instance of Interop\Amqp\AmqpTopic but got Enqueue\NoEffect\NullTopic.');
$context->createConsumer(new NullTopic('aName'));
}

2 changes: 1 addition & 1 deletion pkg/amqp-ext/composer.json
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@
"require-dev": {
"phpunit/phpunit": "^9.5",
"enqueue/test": "0.10.x-dev",
"enqueue/null": "0.10.x-dev",
"enqueue/noeffect": "0.10.x-dev",
"queue-interop/queue-spec": "^0.6.2",
"empi89/php-amqp-stubs": "*@dev"
},
2 changes: 1 addition & 1 deletion pkg/amqp-lib/Tests/AmqpConsumerTest.php
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@

use Enqueue\AmqpLib\AmqpConsumer;
use Enqueue\AmqpLib\AmqpContext;
use Enqueue\Null\NullMessage;
use Enqueue\NoEffect\NullMessage;
use Enqueue\Test\ClassExtensionTrait;
use Enqueue\Test\WriteAttributeTrait;
use Interop\Amqp\Impl\AmqpMessage;
2 changes: 1 addition & 1 deletion pkg/amqp-lib/composer.json
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@
"require-dev": {
"phpunit/phpunit": "^9.5",
"enqueue/test": "0.10.x-dev",
"enqueue/null": "0.10.x-dev",
"enqueue/noeffect": "0.10.x-dev",
"queue-interop/queue-spec": "^0.6.2"
},
"support": {
2 changes: 1 addition & 1 deletion pkg/amqp-tools/composer.json
Original file line number Diff line number Diff line change
@@ -14,7 +14,7 @@
"require-dev": {
"phpunit/phpunit": "^9.5",
"enqueue/test": "0.10.x-dev",
"enqueue/null": "0.10.x-dev"
"enqueue/noeffect": "0.10.x-dev"
},
"support": {
"email": "opensource@forma-pro.com",
4 changes: 2 additions & 2 deletions pkg/async-command/Tests/Functional/UseCasesTest.php
Original file line number Diff line number Diff line change
@@ -6,8 +6,8 @@
use Enqueue\AsyncCommand\RunCommand;
use Enqueue\AsyncCommand\RunCommandProcessor;
use Enqueue\Consumption\Result;
use Enqueue\Null\NullContext;
use Enqueue\Null\NullMessage;
use Enqueue\NoEffect\NullContext;
use Enqueue\NoEffect\NullMessage;
use Interop\Queue\Message;
use PHPUnit\Framework\TestCase;

2 changes: 1 addition & 1 deletion pkg/async-command/composer.json
Original file line number Diff line number Diff line change
@@ -19,7 +19,7 @@
"symfony/http-kernel": "^5.1|^6.0",
"symfony/filesystem": "^5.1|^6.0",
"symfony/yaml": "^5.1|^6.0",
"enqueue/null": "0.10.x-dev",
"enqueue/noeffect": "0.10.x-dev",
"enqueue/fs": "0.10.x-dev",
"enqueue/test": "0.10.x-dev"
},
4 changes: 2 additions & 2 deletions pkg/async-event-dispatcher/Tests/AsyncListenerTest.php
Original file line number Diff line number Diff line change
@@ -5,8 +5,8 @@
use Enqueue\AsyncEventDispatcher\AsyncListener;
use Enqueue\AsyncEventDispatcher\EventTransformer;
use Enqueue\AsyncEventDispatcher\Registry;
use Enqueue\Null\NullMessage;
use Enqueue\Null\NullQueue;
use Enqueue\NoEffect\NullMessage;
use Enqueue\NoEffect\NullQueue;
use Enqueue\Test\ClassExtensionTrait;
use Enqueue\Test\ReadAttributeTrait;
use Interop\Queue\Context;
4 changes: 2 additions & 2 deletions pkg/async-event-dispatcher/Tests/AsyncProcessorTest.php
Original file line number Diff line number Diff line change
@@ -7,8 +7,8 @@
use Enqueue\AsyncEventDispatcher\EventTransformer;
use Enqueue\AsyncEventDispatcher\Registry;
use Enqueue\Consumption\Result;
use Enqueue\Null\NullContext;
use Enqueue\Null\NullMessage;
use Enqueue\NoEffect\NullContext;
use Enqueue\NoEffect\NullMessage;
use Enqueue\Test\ClassExtensionTrait;
use Interop\Queue\Processor;
use PHPUnit\Framework\MockObject\MockObject;
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@

use Enqueue\AsyncEventDispatcher\EventTransformer;
use Enqueue\AsyncEventDispatcher\PhpSerializerEventTransformer;
use Enqueue\Null\NullMessage;
use Enqueue\NoEffect\NullMessage;
use Enqueue\Test\ClassExtensionTrait;
use Interop\Queue\Context;
use Interop\Queue\Message;
2 changes: 1 addition & 1 deletion pkg/async-event-dispatcher/composer.json
Original file line number Diff line number Diff line change
@@ -18,7 +18,7 @@
"symfony/http-kernel": "^5.1|^6.0",
"symfony/filesystem": "^5.1|^6.0",
"symfony/yaml": "^5.1|^6.0",
"enqueue/null": "0.10.x-dev",
"enqueue/noeffect": "0.10.x-dev",
"enqueue/fs": "0.10.x-dev",
"enqueue/test": "0.10.x-dev"
},
2 changes: 1 addition & 1 deletion pkg/dbal/composer.json
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@
"require-dev": {
"phpunit/phpunit": "^9.5",
"enqueue/test": "0.10.x-dev",
"enqueue/null": "0.10.x-dev",
"enqueue/noeffect": "0.10.x-dev",
"queue-interop/queue-spec": "^0.6.2"
},
"support": {
Original file line number Diff line number Diff line change
@@ -7,8 +7,8 @@
use Enqueue\Bundle\Tests\Functional\App\TestAsyncListener;
use Enqueue\Bundle\Tests\Functional\App\TestAsyncSubscriber;
use Enqueue\Bundle\Tests\Functional\WebTestCase;
use Enqueue\Null\NullContext;
use Enqueue\Null\NullMessage;
use Enqueue\NoEffect\NullContext;
use Enqueue\NoEffect\NullMessage;
use Enqueue\Util\JSON;
use Interop\Queue\Processor;
use Symfony\Component\EventDispatcher\GenericEvent;
2 changes: 1 addition & 1 deletion pkg/enqueue/Resources.php
Original file line number Diff line number Diff line change
@@ -10,7 +10,7 @@
use Enqueue\Gearman\GearmanConnectionFactory;
use Enqueue\Gps\GpsConnectionFactory;
use Enqueue\Mongodb\MongodbConnectionFactory;
use Enqueue\Null\NullConnectionFactory;
use Enqueue\NoEffect\NullConnectionFactory;
use Enqueue\Pheanstalk\PheanstalkConnectionFactory;
use Enqueue\RdKafka\RdKafkaConnectionFactory;
use Enqueue\Redis\RedisConnectionFactory;
Original file line number Diff line number Diff line change
@@ -8,8 +8,8 @@
use Enqueue\Client\Message;
use Enqueue\Consumption\Context\MessageReceived;
use Enqueue\Consumption\Result;
use Enqueue\Null\NullMessage;
use Enqueue\Null\NullQueue;
use Enqueue\NoEffect\NullMessage;
use Enqueue\NoEffect\NullQueue;
use Enqueue\Test\TestLogger;
use Interop\Queue\Consumer;
use Interop\Queue\Context as InteropContext;
Original file line number Diff line number Diff line change
@@ -9,8 +9,8 @@
use Enqueue\Client\RouteCollection;
use Enqueue\Consumption\Context\MessageReceived;
use Enqueue\Consumption\MessageReceivedExtensionInterface;
use Enqueue\Null\NullMessage;
use Enqueue\Null\NullQueue;
use Enqueue\NoEffect\NullMessage;
use Enqueue\NoEffect\NullQueue;
use Enqueue\Test\ClassExtensionTrait;
use Interop\Queue\Consumer;
use Interop\Queue\Context as InteropContext;
Original file line number Diff line number Diff line change
@@ -13,8 +13,8 @@
use Enqueue\Consumption\PostMessageReceivedExtensionInterface;
use Enqueue\Consumption\Result;
use Enqueue\Consumption\StartExtensionInterface;
use Enqueue\Null\NullMessage;
use Enqueue\Null\NullQueue;
use Enqueue\NoEffect\NullMessage;
use Enqueue\NoEffect\NullQueue;
use Enqueue\Test\ClassExtensionTrait;
use Enqueue\Util\Stringify;
use Interop\Queue\Consumer;
Original file line number Diff line number Diff line change
@@ -7,8 +7,8 @@
use Enqueue\Client\DriverInterface;
use Enqueue\Consumption\Context\MessageReceived;
use Enqueue\Consumption\MessageReceivedExtensionInterface;
use Enqueue\Null\NullMessage;
use Enqueue\Null\NullQueue;
use Enqueue\NoEffect\NullMessage;
use Enqueue\NoEffect\NullQueue;
use Enqueue\Test\ClassExtensionTrait;
use Interop\Queue\Consumer;
use Interop\Queue\Context as InteropContext;
2 changes: 1 addition & 1 deletion pkg/enqueue/Tests/Client/DelegateProcessorTest.php
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@

use Enqueue\Client\Config;
use Enqueue\Client\DelegateProcessor;
use Enqueue\Null\NullMessage;
use Enqueue\NoEffect\NullMessage;
use Enqueue\ProcessorRegistryInterface;
use Interop\Queue\Context;
use Interop\Queue\Processor;
6 changes: 3 additions & 3 deletions pkg/enqueue/Tests/Client/Driver/GenericDriverTest.php
Original file line number Diff line number Diff line change
@@ -7,9 +7,9 @@
use Enqueue\Client\Driver\GenericDriver;
use Enqueue\Client\DriverInterface;
use Enqueue\Client\MessagePriority;
use Enqueue\Null\NullMessage;
use Enqueue\Null\NullQueue;
use Enqueue\Null\NullTopic;
use Enqueue\NoEffect\NullMessage;
use Enqueue\NoEffect\NullQueue;
use Enqueue\NoEffect\NullTopic;
use Enqueue\Test\ClassExtensionTrait;
use Interop\Queue\Context;
use Interop\Queue\Message as InteropMessage;
4 changes: 2 additions & 2 deletions pkg/enqueue/Tests/Client/DriverFactoryTest.php
Original file line number Diff line number Diff line change
@@ -28,8 +28,8 @@
use Enqueue\Gps\GpsContext;
use Enqueue\Mongodb\MongodbConnectionFactory;
use Enqueue\Mongodb\MongodbContext;
use Enqueue\Null\NullConnectionFactory;
use Enqueue\Null\NullContext;
use Enqueue\NoEffect\NullConnectionFactory;
use Enqueue\NoEffect\NullContext;
use Enqueue\Pheanstalk\PheanstalkConnectionFactory;
use Enqueue\Pheanstalk\PheanstalkContext;
use Enqueue\RdKafka\RdKafkaConnectionFactory;
6 changes: 3 additions & 3 deletions pkg/enqueue/Tests/Client/RouterProcessorTest.php
Original file line number Diff line number Diff line change
@@ -10,8 +10,8 @@
use Enqueue\Client\RouteCollection;
use Enqueue\Client\RouterProcessor;
use Enqueue\Consumption\Result;
use Enqueue\Null\NullContext;
use Enqueue\Null\NullMessage;
use Enqueue\NoEffect\NullContext;
use Enqueue\NoEffect\NullMessage;
use Enqueue\Test\ClassExtensionTrait;
use Enqueue\Test\ReadAttributeTrait;
use Interop\Queue\Destination;
@@ -188,7 +188,7 @@ public function testShouldDoNotModifyOriginalMessage()

$result = $processor->process($message, new NullContext());

//guard
// guard
$this->assertEquals(Result::ACK, $result->getStatus());

$this->assertSame('theBody', $message->getBody());
2 changes: 1 addition & 1 deletion pkg/enqueue/Tests/ConnectionFactoryFactoryTest.php
Original file line number Diff line number Diff line change
@@ -12,7 +12,7 @@
use Enqueue\Gearman\GearmanConnectionFactory;
use Enqueue\Gps\GpsConnectionFactory;
use Enqueue\Mongodb\MongodbConnectionFactory;
use Enqueue\Null\NullConnectionFactory;
use Enqueue\NoEffect\NullConnectionFactory;
use Enqueue\Pheanstalk\PheanstalkConnectionFactory;
use Enqueue\RdKafka\RdKafkaConnectionFactory;
use Enqueue\Redis\RedisConnectionFactory;
4 changes: 2 additions & 2 deletions pkg/enqueue/Tests/Consumption/CallbackProcessorTest.php
Original file line number Diff line number Diff line change
@@ -3,8 +3,8 @@
namespace Enqueue\Tests\Consumption;

use Enqueue\Consumption\CallbackProcessor;
use Enqueue\Null\NullContext;
use Enqueue\Null\NullMessage;
use Enqueue\NoEffect\NullContext;
use Enqueue\NoEffect\NullMessage;
use Enqueue\Test\ClassExtensionTrait;
use Interop\Queue\Processor;
use PHPUnit\Framework\TestCase;
4 changes: 2 additions & 2 deletions pkg/enqueue/Tests/Consumption/Extension/LogExtensionTest.php
Original file line number Diff line number Diff line change
@@ -12,8 +12,8 @@
use Enqueue\Consumption\PostMessageReceivedExtensionInterface;
use Enqueue\Consumption\Result;
use Enqueue\Consumption\StartExtensionInterface;
use Enqueue\Null\NullMessage;
use Enqueue\Null\NullQueue;
use Enqueue\NoEffect\NullMessage;
use Enqueue\NoEffect\NullQueue;
use Enqueue\Test\ClassExtensionTrait;
use Enqueue\Util\Stringify;
use Interop\Queue\Consumer;
Original file line number Diff line number Diff line change
@@ -6,8 +6,8 @@
use Enqueue\Consumption\Extension\ReplyExtension;
use Enqueue\Consumption\PostMessageReceivedExtensionInterface;
use Enqueue\Consumption\Result;
use Enqueue\Null\NullMessage;
use Enqueue\Null\NullQueue;
use Enqueue\NoEffect\NullMessage;
use Enqueue\NoEffect\NullQueue;
use Enqueue\Test\ClassExtensionTrait;
use Interop\Queue\Consumer;
use Interop\Queue\Context;
2 changes: 1 addition & 1 deletion pkg/enqueue/Tests/Consumption/QueueConsumerTest.php
Original file line number Diff line number Diff line change
@@ -20,7 +20,7 @@
use Enqueue\Consumption\ExtensionInterface;
use Enqueue\Consumption\QueueConsumer;
use Enqueue\Consumption\Result;
use Enqueue\Null\NullQueue;
use Enqueue\NoEffect\NullQueue;
use Enqueue\Test\ReadAttributeTrait;
use Enqueue\Tests\Consumption\Mock\BreakCycleExtension;
use Enqueue\Tests\Consumption\Mock\DummySubscriptionConsumer;
2 changes: 1 addition & 1 deletion pkg/enqueue/Tests/Consumption/ResultTest.php
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@
namespace Enqueue\Tests\Consumption;

use Enqueue\Consumption\Result;
use Enqueue\Null\NullMessage;
use Enqueue\NoEffect\NullMessage;
use PHPUnit\Framework\TestCase;

class ResultTest extends TestCase
4 changes: 2 additions & 2 deletions pkg/enqueue/Tests/Router/RouteRecipientListProcessorTest.php
Original file line number Diff line number Diff line change
@@ -3,8 +3,8 @@
namespace Enqueue\Tests\Router;

use Enqueue\Consumption\Result;
use Enqueue\Null\NullMessage;
use Enqueue\Null\NullQueue;
use Enqueue\NoEffect\NullMessage;
use Enqueue\NoEffect\NullQueue;
use Enqueue\Router\Recipient;
use Enqueue\Router\RecipientListRouterInterface;
use Enqueue\Router\RouteRecipientListProcessor;
2 changes: 1 addition & 1 deletion pkg/enqueue/Tests/Rpc/PromiseTest.php
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@

namespace Enqueue\Tests\Rpc;

use Enqueue\Null\NullMessage;
use Enqueue\NoEffect\NullMessage;
use Enqueue\Rpc\Promise;
use PHPUnit\Framework\TestCase;

6 changes: 3 additions & 3 deletions pkg/enqueue/Tests/Rpc/RpcClientTest.php
Original file line number Diff line number Diff line change
@@ -2,9 +2,9 @@

namespace Enqueue\Tests\Rpc;

use Enqueue\Null\NullContext;
use Enqueue\Null\NullMessage;
use Enqueue\Null\NullQueue;
use Enqueue\NoEffect\NullContext;
use Enqueue\NoEffect\NullMessage;
use Enqueue\NoEffect\NullQueue;
use Enqueue\Rpc\Promise;
use Enqueue\Rpc\RpcClient;
use Interop\Queue\Consumer;
2 changes: 1 addition & 1 deletion pkg/enqueue/Tests/Symfony/Client/ConsumeCommandTest.php
Original file line number Diff line number Diff line change
@@ -13,7 +13,7 @@
use Enqueue\Consumption\QueueConsumer;
use Enqueue\Consumption\QueueConsumerInterface;
use Enqueue\Container\Container;
use Enqueue\Null\NullQueue;
use Enqueue\NoEffect\NullQueue;
use Enqueue\Symfony\Client\ConsumeCommand;
use Enqueue\Test\ClassExtensionTrait;
use Interop\Queue\Consumer;
Original file line number Diff line number Diff line change
@@ -5,7 +5,7 @@
use Enqueue\Client\Config;
use Enqueue\Client\Driver\GenericDriver;
use Enqueue\Client\RouteCollection;
use Enqueue\Null\NullContext;
use Enqueue\NoEffect\NullContext;
use Enqueue\Symfony\Client\SetupBrokerExtensionCommandTrait;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
Loading
Oops, something went wrong.