PHP 8.4 support #148
Open
PHP 8.4 support #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these never appeared prior to 8.4, but show up now because of php/php-src@1e7aac315ef1 During finalization of rope compilation, previously used literal slots may become unused and get turned into IS_UNDEF.
|
Test failure looks to be caused by incorrect refcounts on string copies for zend_property_info, not sure how to address that just yet but my gawd is it ever irritating. |
… exists fo classes that were unlinked during first copy, we might've already copied the relevant property info to the destination thread. In this case in the past, this would just silently fail to insert the updated property info and go on to free it. We probably ought to get rid of the old property_info and replace it with the newly copied version, but for now this restores the original behaviour, which seemed to work anyway??? However, possible that this may break with property hooks inheritance. Needs further testing.
|
Is it ready to support php 8.4? |
|
No, it's not complete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thanks to @AkmalFairuz for initial work, this PR is based on his work from #142