Skip to content

Grammatical fixes. #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

decibel
Copy link

@decibel decibel commented Aug 24, 2016

NOTE! I stuck a comment in the documentation about # >= 10 AND # <= 20, because I believe the documentation is incorrect.

Also, if you want to encourage users to create issues for feature requests then a better option for the very last paragraph would be:

If there's some functionality you'd like to see added to JsQuery, please create a github issue. We welcome pull requests, but it would be best to open an issue for discussion first.

Jim Nasby added 2 commits August 24, 2016 18:25
NOTE! I stuck a comment in the documentation about `# >= 10 AND # <= 20`, because I believe the documentation is incorrect.

Also, if you want to encourage users to create issues for feature requests then a better option for the very last paragraph would be:

If there's some functionality you'd like to see added to JsQuery, please [create a github issue](https://github.com/akorotkov/jsquery/issues). We welcome pull requests, but it would be best to open an issue for discussion first.
@sokolcati
Copy link
Contributor

Hi!
Thank you for your contribution to the development of the module.
I'd like to use some grammatical fixes, but not change the title and documentation:

  1. The title does not contain an obvious grammatical problem, but is already familiar to users.
  2. There is NO error in the documentation (about # >= 10 AND # <= 20). Note that this example illustrates the fact stated above in the documentation text.

Usage of path operators and braces need some explanation. When same path operators are used multiple times they may refer different values while you can refer same value multiple time by using braces and $ operator.

@sokolcati
Copy link
Contributor

I took a commit 5d8b4d1200ba3bad1487604184a9d202ff9ba45c from this request, removed conflicts, changed it a little, and did not use some of the changes.
Thanks for your contribution! Final commit 8bc077da0b4f24158059b42e47caeee3fd1cb1bf

@sokolcati sokolcati closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants