Skip to content

remove additional and useless loop for each relation file when do ptrack_get_pagemapset query #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2022

Conversation

vegebird
Copy link
Contributor

remove additional and useless loop for each relation file when do ptrack_get_pagemapset query reported by #12

@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #17 (a34e6c3) into master (6f1a27b) will increase coverage by 1.22%.
The diff coverage is 100.00%.

❗ Current head a34e6c3 differs from pull request most recent head 820380a. Consider uploading reports for the commit 820380a to get more accurate results

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   87.40%   88.63%   +1.22%     
==========================================
  Files           2        2              
  Lines         381      431      +50     
==========================================
+ Hits          333      382      +49     
- Misses         48       49       +1     
Impacted Files Coverage Δ
ptrack.c 93.10% <100.00%> (+1.60%) ⬆️
engine.c 84.64% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f1a27b...820380a. Read the comment docs.

@vegebird
Copy link
Contributor Author

@ololobus Hello Alexey, could you please have a look at this PR ?
In rainy day scenarios, ptrack_get_pagemapset() may return error pagecount/pagemap for the changed relation files when do additional ptrack_map->entries[hash] checker and hash collision happens.

@ololobus
Copy link
Contributor

@funny-falcon @kulaginm have a look, when you'll have a chance, please

Copy link
Contributor

@funny-falcon funny-falcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I approve.
Please, accept suggestion on condition.

Co-authored-by: Sokolov Yura <funny.falcon@gmail.com>
@funny-falcon funny-falcon merged commit e1d30bb into postgrespro:master Jun 27, 2022
@vegebird vegebird deleted the mapset-fixes branch July 6, 2022 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants