Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download all sketches of a user as a single zip #2707

Closed
wants to merge 3 commits into from

Conversation

mhsh312
Copy link
Contributor

@mhsh312 mhsh312 commented Dec 10, 2023

Fixes #1939

Changes:

  • Added a Download all sketches button
  • Added Download all sketches in English translation file
  • Added new controller downloadAllProjectsAsZip
  • Added a new library bundling function to handle library bundling in the case of multiple projects

Logic: I created a function called compileProjects that can merge multiple projects into one big project that treats all the projects as subfolders. This compilation follows the JSON format needed for the addFileToZip function to work and thus reuses the same method used for singular project. I also created a new function bundleExternalLibsForCompiledProject that handles bundling library files for the compilation. It adds specific library files to each project folder for that particular project.

image

image

image

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Sorry, something went wrong.

mhsh312 and others added 3 commits December 10, 2023 16:32

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@raclim raclim added this to the MINOR Release for 2.12.0 milestone Jan 8, 2024
@raclim raclim removed this from the MINOR Release for 2.12.0 milestone Mar 8, 2024
@raclim
Copy link
Collaborator

raclim commented Jun 24, 2024

Thanks so much for your work on this!

Due to some of the changes here falling out of date and some of the other features/fixes we'd like to prioritize over the next two months, I'm going to close this pull request for now. I'm really sorry that it took a while to get to this and that we couldn't get this in at the moment, but please feel free to update and reopen this pull request in the future!

@raclim raclim closed this Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature-request: download all sketches as zip
2 participants