-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slugify Sketch Titles, but not publicly exposed #522
Comments
i think this could be expanded a bit:
|
Hi. I would like to work on this issue if no one is currently working. |
@ankur54 go ahead and work on it! |
After a little bit of searching over the internet, I came across a dependency "slugify" npm, which I intend to use. Also, could you please tell me in which file should I make changes? |
slugify is already included, and you can already navigate to sketches via their slug. however, it's never linked to on the front end, so this issue is about linking it on the front end. there's not currently a design for this, and also i have some open questions which i listed above |
a) I think there should be a length limit. Around 40 letters would do, I think. If the length exceeds we can represent it with "...". What do you think? |
a) in #568 there's a discussion about the maximum length of a sketch name. i wonder if that would fix this issue. i think it depends on the maximum length of a url (which off the top of my head, i don't know what that is) |
Nature of issue?
Feature enhancement details:
Right now, the link to sketches are only by the sketch id, which is not very human readable. It would be cool to have human friendly links. For now, the simplest version of this would be to generate a slug every time a sketch is saved from the title of the project, and then a user can navigate to the sketch using that slug by going to
/<username>/sketches/<slug>
.The text was updated successfully, but these errors were encountered: