Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open examples in Processing #618

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Stefterv
Copy link
Contributor

@Stefterv Stefterv commented Mar 17, 2025

The newest beta supports a new schema for opening Sketches in Processing from a link.

This PR adds an Open With Processing button to all the examples on the website.

2025-03-26.10.48.20.mp4

Copy link

netlify bot commented Mar 17, 2025

Deploy Preview for java-processing-faf822 ready!

Name Link
🔨 Latest commit cda5198
🔍 Latest deploy log https://app.netlify.com/sites/java-processing-faf822/deploys/67e3e2746a1bfa000883bd92
😎 Deploy Preview https://deploy-preview-618--java-processing-faf822.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SableRaf SableRaf self-requested a review March 24, 2025 16:33

const OpenWithButton = ({ pdes }) => {
const main = pdes[0]
let sketchURL = `pde://sketch/base64/${stringToBase64(main.code)}?pde=`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesnt this leave an extra ?pde= at the end of the URL?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary? Could we avoid it?

@SableRaf SableRaf self-requested a review March 26, 2025 09:54
@SableRaf
Copy link
Collaborator

SableRaf commented Mar 26, 2025

I made some changes to the styling and content of the tooltip and made it dismissable by clicking outside of it.

@Stefterv: my code may not be the cleanest so feel free to make edits.

2025-03-27.14.41.28.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants