Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix black / flake8 on all files #346

Open
manulera opened this issue Mar 10, 2025 · 3 comments
Open

Fix black / flake8 on all files #346

manulera opened this issue Mar 10, 2025 · 3 comments

Comments

@manulera
Copy link
Collaborator

We should run black / flake8 across all files so that when we make changes they don't get buried on style changes. Black is automatic, so that's an easy one. flake8 will require work, but it's probably worth.

Alternatively, when making a change if you realise that there will be flake8/black changes, you can create a first commit with black/flake8 fixes, then the actual change.

@manulera
Copy link
Collaborator Author

cc @BjornFJohansson

@BjornFJohansson
Copy link
Collaborator

I think this is a good idea. I don't really know how these tools work in detail. Is there perhaps some flake8 (AI) tool that can edit the files automatically? There seems to be something called autopep.

I think it should wait until I have made the changes for the new Dseq implementation.

@manulera
Copy link
Collaborator Author

I think it would be good to do it before the changes, because otherwise reviewing the diffs will be impossible since most changes will be style changes and not actual code changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants