-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disaggregate shiftlocus #914
base: main
Are you sure you want to change the base?
Disaggregate shiftlocus #914
Conversation
src/methods/aggregate.jl
Outdated
end | ||
return maybeshiftlocus(loc, newlookup) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The double locus shift is a bit worrying, easy to introduce fp errors? Can we not explicitly create start/center/end lookups instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah it's not ideal - let's find a better solution
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #914 +/- ##
==========================================
+ Coverage 82.32% 83.25% +0.92%
==========================================
Files 60 58 -2
Lines 4357 5387 +1030
==========================================
+ Hits 3587 4485 +898
- Misses 770 902 +132 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Okay I gave it a go now with a more proper fix and added some tests to show what my goal is here. Some of the tests fail and I'm not totally sure how to fix them yet, will look more at it later. But it also seems the tests 1) still use some old (deprecated?) syntax (e.g. passing a locus to |
closes #913