Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disaggregate shiftlocus #914

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tiemvanderdeure
Copy link
Collaborator

closes #913

end
return maybeshiftlocus(loc, newlookup)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The double locus shift is a bit worrying, easy to introduce fp errors? Can we not explicitly create start/center/end lookups instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it's not ideal - let's find a better solution

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.25%. Comparing base (a15ebb1) to head (e0752c6).
Report is 166 commits behind head on main.

Files with missing lines Patch % Lines
src/methods/aggregate.jl 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #914      +/-   ##
==========================================
+ Coverage   82.32%   83.25%   +0.92%     
==========================================
  Files          60       58       -2     
  Lines        4357     5387    +1030     
==========================================
+ Hits         3587     4485     +898     
- Misses        770      902     +132     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tiemvanderdeure
Copy link
Collaborator Author

Okay I gave it a go now with a more proper fix and added some tests to show what my goal is here.

Some of the tests fail and I'm not totally sure how to fix them yet, will look more at it later.

But it also seems the tests 1) still use some old (deprecated?) syntax (e.g. passing a locus to disaggregate), and 2) mostly test point Rasters, where I think most of the actual usage of (dis)aggregate will be on interval sampling. It's also much more intuitive what disaggregation of intervals should look like vs disaggregation of points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disaggregate does not preserve extent
2 participants