Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[create-react-scripts-ssr] Make sure publicPath end with slash #3

Closed
raymondsze opened this issue Oct 9, 2017 · 0 comments
Closed

[create-react-scripts-ssr] Make sure publicPath end with slash #3

raymondsze opened this issue Oct 9, 2017 · 0 comments

Comments

@raymondsze
Copy link
Owner

If the webpack config output public path does not end with '/'.
The filepath generated in dll-assets.json could be wrong.
raymondsze added a commit that referenced this issue Oct 9, 2017
@raymondsze
Merge pull request #4 from raymondsze/fix-dll-publicPath
78337cd 
fixes #3 make sure publicPath must end with slash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@raymondsze